Added dynamic control over CS between SPI DMA transfers#26
Open
Blackaddr wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to use the DmaSpi for accessing SPI memory, such as the LC1024 on the Teensy Audio board. I have tested these changes in my BAGuitar repo, branch dma_spi. The library also did not compile on Teensy 3.2 because SPI1 doesn't exist. I've wrapped the SPI1 code in processor based defines similar to other libraries.
I have added to DmaSpi library dynamic control over the chip select behaviour from one transfer the next. This is necessary with SPI memories because they expect the first four bytes following CS activation to be command and address, then the payload follows. Backwards compatible behaviour is maintained.
The following procedure is required for DMA transfer to SPI memory
This avoid having to copy the command/address and data payload into a single contiguous memory buffer.
E.g. Register the first transfer:
commandXfer = DmaSpi::Transfer(commandAddress, 4, nullptr, 0, cs, TransferType::NO_END_CS);
payloadXfer = DmaSpi::Transfer(payload, payloadSize, nulltpr, 0, cs, TransferType::NO_START_CS);
regularXfer = DmaSpi::Transfer(src, size, nullptr, 0, cs); // Default is TransferType::NORMAL
Please let me know if you have any questions!