Fix 1892#1893
Merged
Merged
Conversation
…used-type-ignore-comment
ty is run unpinned (we ride the latest release and adjust the ignore
list as it evolves). ty 0.0.53 began emitting two diagnostic classes on
existing, unchanged source that the check-typing recipe did not ignore,
so `ty check` exited 1 and Code Quality Checks went red:
- 921x possibly-missing-submodule (vendored FlatBuffers-generated code
under src/autobahn/wamp/gen/** plus a few flatbuffers.* re-export
sites in message_fbs.py / message.py / protocol.py)
- 1x unused-type-ignore-comment (src/autobahn/util.py:1062)
0 errors; all warnings. Drift, not a code regression: master was green
on 2026-06-19 with an earlier ty, and went red on a 2026-06-25 run that
pulled ty 0.0.53 (surfaced on the unrelated example-cleanup PR crossbario#1887).
Add both rules to the check-typing --ignore list. Reproduced red->green
locally with ty 0.0.53 against the cpy311 venv: 922 diagnostics/exit 1
before, "All checks passed!"/exit 0 after.
Note: This work was completed with AI assistance (Claude Code).
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1892