Skip to content

Fix "JSON.generate: UTF-8 string passed as BINARY" warning for text attachments #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreaslillebo wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix "JSON.generate: UTF-8 string passed as BINARY" warning for text attachments #762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e55a533
Fix "JSON.generate: UTF-8 string passed as BINARY" warning for text a…
andreaslillebo May 7, 2026
a9fc849
Address rubocop offenses
andreaslillebo May 7, 2026
3485a5f
Merge branch 'main' into text-attachment-encoding-tag
crmne May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/ruby_llm/attachment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def active_storage?
@source.is_a?(ActiveStorage::Attached::Many)
end

def content
def content # rubocop:disable Metrics/PerceivedComplexity
return @content if defined?(@content) && !@content.nil?

if url?
Expand All @@ -53,6 +53,8 @@ def content
nil
end

@content&.force_encoding(Encoding::UTF_8) if text?

@content
end

Expand Down
1 change: 1 addition & 0 deletions spec/fixtures/multilingual.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Hei på deg
6 changes: 6 additions & 0 deletions spec/ruby_llm/attachment_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,10 @@
expect(status.success?).to be(true), stderr
expect(stdout.strip).to eq('ruby.txt,text/plain')
end

it 'serializes non-ASCII text/* attachment content as JSON' do
attachment = described_class.new('spec/fixtures/multilingual.txt')

expect { JSON.generate(text: attachment.content) }.not_to output.to_stderr
end
end
Loading