-
Notifications
You must be signed in to change notification settings - Fork 7.6k
fix: add missing ExecutorContext methods to AgentExecutor for human_input support #6352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
C1-BA-B1-F3
wants to merge
1
commit into
crewAIInc:main
Choose a base branch
from
C1-BA-B1-F3:fix/human-input-agent-executor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+117
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major
🧩 Analysis chain
🏁 Script executed:
Repository: crewAIInc/crewAI
Length of output: 50372
Feedback rerun resets too little execution state – carried-over
iterationsshort-circuits max-iteration checks and skips native tool setup.Both
_invoke_loopand_ainvoke_looponly reset_finalize_calledandstate.is_finishedbefore re-runningkickoff(). In contrast,invoke()(Lines 2742–2755) performs a comprehensive reset includingstate.iterations = 0,state.current_answer = None,state.use_native_tools = False, andstate.pending_tool_calls = [].Because
state.iterationscarries over from the first run,check_max_iterations(Line 2114) evaluates against the prior count. For agents that consumed several iterations before producing the firstAgentFinish, the feedback rerun can immediately route toforce_final_answer, causing human feedback to be ignored. Additionally,initialize_reasoning(Line 1343) skips native tool detection whenstate.iterations != 0, leaving the executor in an inconsistent state wherestate.use_native_toolsreflects the previous run.A simple direct-answer agent (iterations 0) appears to work, but multi-iteration agents will regress on feedback reruns. Reset the missing state fields before re-running the loop.
🔧 Required state reset in feedback loops
def _invoke_loop(self) -> AgentFinish: ... self._finalize_called = False self.state.is_finished = False + self.state.iterations = 0 + self.state.current_answer = None + self.state.use_native_tools = False + self.state.pending_tool_calls = [] self.kickoff()Apply the same changes in
_ainvoke_loopbeforeawait self.kickoff_async().📝 Committable suggestion
🤖 Prompt for AI Agents