Updates to Dependencies, Build Chain, and Examples - #374
Conversation
- replace eslint with oxlint - add vscode suggested extensions and settings - replace npm test:plus w/ npm check
Node 18 was end-of-lifed in March 2025. Production cql-execution still works with it, but some of our dev/test libraries don't.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #374 +/- ##
==========================================
- Coverage 89.57% 88.70% -0.87%
==========================================
Files 55 59 +4
Lines 4855 4933 +78
Branches 1391 1429 +38
==========================================
+ Hits 4349 4376 +27
Misses 322 322
- Partials 184 235 +51 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dehall
left a comment
There was a problem hiding this comment.
This looks good to me and I'd be ok with merging as-is. But since it has been a couple weeks since this was submitted you may want to bump dependencies one more time just to get the latest.
My only concern is that this is the kind of PR where the things that go wrong are things I wasn't aware of, like how others interact with the library. But to your point, I think if we bump the major version number then anyone who is using this should be able to figure out any breaking changes.
|
@dehall - your comments have been addressed. Based on your comment, I think you are advising we bump a major version, right? (BTW -- I'll also update the GH merge criteria to no longer check cql4browsers once this is ready to merge to master). |
I guess to be precise I would say, I think that the next tagged release (whenever that is) should be a bump to the major version. I'm also thinking about my Decimal changes which will impact how users interact with this library, so I'd propose waiting for that before releasing the next version. The fqm-execution team also wants to do a more detailed regression test as well. (And let's also consider if there's anything else we want to try to get in before that. For example I'd kind of like to take a little time to do a quick pass of tightening up types and reducing the use of |
|
Just chiming in here since I was able to run a large regression test on this PR vs master with fqm-execution. No changes with results or issues at all. This gets a thumbs up from me. 👍 |
|
Thank you for the reviews and testing, @dehall and @hossenlopp. Dylan -- holding off a release until the Decimal work (and possibly more breaking changes) sounds like a good plan. |
This PR makes non-trivial updates to some of our dependencies, our build chain, and our examples. These changes include:
Some of these changes might be considered breaking (particularly dropping Node 18 and dropping cql4browsers), so we should consider if this warrants a major version change. In practice, I doubt this will break any existing implementations, but if we follow semver strictly, we probably should bump it.
Submitter:
npm run test:plusto run tests, lint, and prettier)cql4browsers.jsbuilt withnpm run build:browserifyif source changed.Reviewer:
Name: