test: validate outgoing request format in UPStrack and getUPS#33
Draft
toddr-bot wants to merge 1 commit into
Draft
test: validate outgoing request format in UPStrack and getUPS#33toddr-bot wants to merge 1 commit into
toddr-bot wants to merge 1 commit into
Conversation
The existing tests mock HTTP responses but never verify the outgoing request format. If someone refactors the request construction (URL, headers, or payload), all tests still pass because mocks return fixed data regardless of input. Add subtests that capture and validate: - UPStrack: POST URL, Content-Type header, JSON payload structure (Locale, TrackingNumber array), and tracking number passthrough - getUPS: base URL, license agreement param, required query params (product, origin, dest, weight) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add tests that verify the HTTP requests sent by
UPStrack()andgetUPS(), not just the response parsing.Why
Existing tests mock HTTP responses but never inspect the outgoing request. If someone refactors request construction — changes the URL, drops a header, or alters the JSON payload — all tests still pass because mocks return fixed data regardless of what was sent. This is a real regression risk.
How
Content-Typeheader, and JSON body. Validates endpoint URL, header value, payload structure (Locale,TrackingNumberarray), and that the tracking number from input appears in the payload.Testing
make test— 26 tests pass (was 24 before, +2 new subtests with multiple assertions each).🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 92 insertions(+)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline