test: remove dual-denom test paths and add invariants coverage#1185
test: remove dual-denom test paths and add invariants coverage#1185aljo242 wants to merge 3 commits into
Conversation
Drop remaining 6/12-decimal test-support paths now that only 18-decimal configs are supported, and add randomized conversion invariants plus a scaling fuzz target to harden regression coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
Greptile SummaryThis PR removes all non-18-decimal test fixtures and constants (
Confidence Score: 5/5Safe to merge — all changes are test-only, removing dead dual-decimal paths and adding well-guarded new coverage. All modifications are confined to test files and documentation. The non-18-decimal constants and chain IDs are cleanly removed, the rejection tests are correctly rewritten with inline fixtures, the randomized invariant test properly guards against zero-balance panics, and the fuzz target uint64 overflow is addressed with both a runtime guard and a dedicated regression unit test. No files require special attention. Important Files Changed
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1185 +/- ##
==========================================
+ Coverage 66.32% 66.92% +0.60%
==========================================
Files 336 320 -16
Lines 23959 23409 -550
==========================================
- Hits 15891 15667 -224
+ Misses 6891 6583 -308
+ Partials 1177 1159 -18 🚀 New features to boost your workflow:
|
Address PR feedback by guarding the fuzz input against uint64 overflow and rename local variables that shadow Go builtins so lint passes cleanly. Co-authored-by: Cursor <cursoragent@cursor.com>
Add deterministic boundary coverage around conversion invariants, include a regression test for the MaxUint64 fuzz edge case, and document local commands for running the denom conversion fuzz target. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@greptile re-review |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
Summary
Test plan
go test -tags=test ./x/vm/types ./utilsgo test -tags=test ./tests/integration/testutilgo test -tags=test ./tests/integration -run 'TestERC20KeeperTestSuite|TestWERC20PrecompileUnitTestSuite'(fromevmd/)Made with Cursor