Skip to content

Build css modules using webpack in prod build #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coryhouse wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Build css modules using webpack in prod build #17

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85cc1ef
Enable css-modules. Build css module using webpack in prod build
Dec 19, 2017
78a2fc7
WIP in Porto! Woot!
Jan 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/paths.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function getServedPath(appPackageJson) {
// config after eject: we're in ./config/
module.exports = {
dotenv: resolveApp('.env'),
appBuild: resolveApp('build'),
appBuild: resolveApp('lib'),
appPublic: resolveApp('public'),
appHtml: resolveApp('public/index.html'),
appIndexJs: resolveApp('src/index.js'),
Expand Down
5 changes: 2 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,12 @@
"gen:docs-watch": "npm run gen:docs -- --watch",
"build:docs": "node scripts/build.js",
"test": "node scripts/test.js --env=jsdom",
"build:css": "cross-env NODE_ENV=production webpack --config config/webpack.config.prod.js",
"prebuild:lib": "rimraf lib",
"build:lib": "npm-run-all --parallel build:commonjs build:css build:copy-files",
"build:lib": "npm-run-all --parallel build:commonjs build:copy-files",
"build:copy-files": "node scripts/copyBuildFiles.js",
"predeploy:docs": "npm run build:docs",
"deploy:docs": "gh-pages -d build",
"build:commonjs": "cross-env NODE_ENV=production babel ./src/components --out-dir ./lib --ignore spec.js",
"build:commonjs": "cross-env NODE_ENV=production webpack --config config/webpack.config.prod.js",

@sag1v sag1v Jan 23, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure webpack can keep the folder structure of the components for both the js and css files?

"prepublish": "npm run build:lib"
},
"jest": {
Expand Down