Avoid underscored functions - #10
Open
DavisVaughan wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for the PR. I was actually contacted by CRAN over Christmas to fix some NOTES (unrelated to dplyr's changes), and in the process also tried to fix the use of I used dplyr::group_by_at(d, g)while you are suggesting to use dplyr::group_by(d, dplyr::pick(dplyr::all_of(g)))Is there any advantages of one over the other? |
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, we are working on the next version of dplyr and your package was flagged in our reverse dependency checks.
Your package uses one of the "underscored" versions of a dplyr verb, such as
mutate_()rather thanmutate(). These were deprecated in 2017, and are now defunct and must be removed.dplyr will be released on January 31, 2026. If you could please send an update of your package to CRAN before then, that would help us out a lot! Thanks!