DGS-24721 Add support for saving Azure key version with DEK#507
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for making Azure Key Vault–wrapped DEKs self-describing by embedding the Azure key version into the encrypted key material, enabling reliable decrypt after key rotation (similar to AWS/GCP KMS ciphertext behavior).
Changes:
- Add an
encrypt.azure.key.version.savetoggle and Azure Key Vault key-id parsing/version resolution utilities. - Update
AzureKmsClientto optionally prefix ciphertext withazure:v1:<32-hex-version>:and to use the embedded version during decrypt. - Propagate per-KEK
kmsPropsinto the config passed to KMS clients, and add Jest coverage for the new Azure behaviors.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| schemaregistry/rules/encryption/encrypt-executor.ts | Merges per-KEK kmsProps into the config used for KMS client creation. |
| schemaregistry/rules/encryption/azurekms/azure-driver.ts | Adds Azure key-id parsing, credentials helper, and version resolution for versionless key IDs. |
| schemaregistry/rules/encryption/azurekms/azure-client.ts | Implements version-prefixed ciphertext format and decrypt-time version selection. |
| schemaregistry/test/rules/encryption/azurekms/azure-driver.spec.ts | Unit tests for Azure key-id parsing/version resolution utilities. |
| schemaregistry/test/rules/encryption/azurekms/azure-client.spec.ts | Unit tests for encrypt/decrypt behavior with and without embedded key version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Justin Wang (Claimundefine)
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please prefix all TypeScript pull-requests with
[Typescript]What
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups