-
Notifications
You must be signed in to change notification settings - Fork 4
Populated JSON sidecars #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b975f14
add JSON for probes
CodyCBakerPhD e23127f
add JSON for electrodes and channels
CodyCBakerPhD 4efec5d
Merge branch 'main' into add_json
CodyCBakerPhD 3602c6c
add comments
CodyCBakerPhD 44ebc99
Merge branch 'main' into add_json
CodyCBakerPhD 3ba88a6
pr review
CodyCBakerPhD 61494c5
Merge branch 'add_json' of https://github.com/con/nwb2bids into add_json
CodyCBakerPhD e64c09b
pr review
CodyCBakerPhD 254e43a
Apply suggestions from code review
CodyCBakerPhD d8ffff7
pr review
CodyCBakerPhD 70eea9e
Merge branch 'add_json' of https://github.com/con/nwb2bids into add_json
CodyCBakerPhD f92b911
pr review
CodyCBakerPhD cf642be
fix pre-commit
CodyCBakerPhD ce90b5f
Merge branch 'main' into add_json
CodyCBakerPhD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import typing | ||
|
|
||
| import pydantic | ||
| import pydantic_core | ||
|
|
||
|
|
||
| def _get_present_fields(models: typing.Sequence[pydantic.BaseModel]) -> set[str]: | ||
| """Return a set of field names that are present or required in the model.""" | ||
| present_non_additional_fields = { | ||
| field | ||
| for model in models | ||
| for field, value in model.model_dump().items() | ||
| if field in model.model_fields | ||
| and ( | ||
| value is not None | ||
| or model.model_fields.get(field, pydantic.fields.FieldInfo()).default is pydantic_core.PydanticUndefined | ||
| ) | ||
| } | ||
| return present_non_additional_fields |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.