Skip to content

kernel/dts: improve coding style#120

Open
okias wants to merge 1 commit into
commaai:masterfrom
okias:mainline-coding-style
Open

kernel/dts: improve coding style#120
okias wants to merge 1 commit into
commaai:masterfrom
okias:mainline-coding-style

Conversation

@okias

@okias okias commented Jun 22, 2026

Copy link
Copy Markdown

No description provided.

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown

vamOS System Profile

Changes vs master

Metric Change
Used space 3496.1MB → 3434.5MB (-61.5MB)
Sparse image 3449.0MB → 3389.3MB (-59.6MB)
Package count 524 → 524

Added packages: MesaLib-devel-26.1.3_1, git-lfs-3.7.1_1, libgbm-26.1.3_1, libgbm-devel-26.1.3_1, mesa-26.1.3_1, mesa-dri-26.1.3_1, mesa-libgallium-26.1.3_1, mesa-opencl-26.1.3_1, nano-9.0_1

Removed packages: MesaLib-devel-26.0.6_2, git-lfs-3.6.1_1, libgbm-26.0.6_2, libgbm-devel-26.0.6_2, mesa-26.0.6_2, mesa-dri-26.0.6_2, mesa-libgallium-26.0.6_2, mesa-opencl-26.0.6_2, nano-8.7_1

Directory size changes (>1MB)
Directory Change

Metric Value
Used space 3434.5MB / 5959.5MB
Files 56113
Directories 4750
Symlinks 3577
Packages 524

Top 10 Directories

Directory Size

Category Breakdown

Category Size %
xbps packages 2502.7MB 72.8%
Python venv 591.7MB 17.2%
Firmware 11.5MB .3%
Other 328.5MB 9.5%

Top 10 Packages by Size

Package Size
mit-krb5-libs-1.21.3_1 270.4MB
gawk-5.3.2_1 210.3MB
llvm-21_3 148.6MB
libldns-1.9.2_1 124.3MB
pd-mapper-1.0_1 73.9MB
libclang21-21.1.7_1 70.2MB
glib-2.88.0_1 67.4MB
gcc-14.2.1+20250405_4 66.6MB
libcap-progs-2.78_1 56MB
cmake-4.2.2_2 53.2MB

Top 30 Files by Size

File Size
/usr/lib/llvm/21/lib/libLLVM.so.21.1 124.3MB
/usr/lib/llvm/21/lib/libMLIR.so.21.1 89.7MB
/usr/lib/llvm/21/bin/mlir-transform-opt 82.9MB
/usr/lib/llvm/21/lib/libclang-cpp.so.21.1 56MB
/usr/lib/llvm/21/bin/mlir-translate 53.2MB
/usr/lib/llvm/21/bin/llvm-exegesis 52MB
/usr/lib/llvm/21/bin/llvm-bolt-binary-analysis 50.6MB
/usr/bin/uv 50MB
/usr/lib/gcc/aarch64-linux-gnu/14.2/gnat1 40.1MB
/usr/bin/gdb 39.1MB
/usr/lib/libgallium-26.1.3.so 37.7MB
/usr/lib/gcc/aarch64-linux-gnu/14.2/cc1plus 37.3MB
/usr/lib/libllvm-qcom.so 35.2MB
/usr/lib/gcc/aarch64-linux-gnu/14.2/cc1 35.2MB
/usr/lib/libRusticlOpenCL.so.1.0.0 34.3MB
/usr/lib/gcc/aarch64-linux-gnu/14.2/lto1 33.9MB
/usr/bin/lto-dump 33.9MB
/usr/local/venv/bin/ruff 31.8MB
/usr/share/icu/78.3/icudt78l.dat 31.5MB
/usr/lib/llvm/21/lib/libclang.so.21.1.7 30.2MB
/usr/lib/llvm/21/bin/c-index-test 28.6MB
/usr/local/venv/lib/python3.12/site-packages/gcc_arm_none_eabi/toolchain/libexec/gcc/arm-none-eabi/13.2.1/cc1 28.2MB
/usr/lib/libz3.so 27.9MB
/usr/bin/run 26.7MB
/usr/local/venv/lib/python3.12/site-packages/numpy.libs/libscipy_openblas64_-71e1b124.so 23.6MB
/usr/comma/updater 23.5MB
/usr/comma/setup 23.5MB
/usr/comma/reset 23.5MB
/usr/local/uv/python/cpython-3.12.13-linux-aarch64-gnu/bin/python3.12 22.2MB
/usr/local/uv/python/cpython-3.12.13-linux-aarch64-gnu/lib/libpython3.12.so.1.0 22.1MB

@andiradulescu

andiradulescu commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

@okias okias force-pushed the mainline-coding-style branch from 7961121 to 4158e1a Compare June 22, 2026 21:15
@okias

okias commented Jun 22, 2026

Copy link
Copy Markdown
Author
  • needs #include <dt-bindings/arm/qcom,ids.h>

Right, thanks.

* `348` was used for 850 support which I think was dropped: [commaai/agnos-kernel-sdm845@fbd247e](https://github.com/commaai/agnos-kernel-sdm845/commit/fbd247ed52d03f026be4da0f66fd1c989dc0873c) / [commaai/agnos-kernel-sdm845@3385112](https://github.com/commaai/agnos-kernel-sdm845/commit/338511267da0d247196e8c044ed89a702ceb770d)

interesting, should be kept there? if yes, I'll just add the ID into the mainline

@andiradulescu

Copy link
Copy Markdown
Collaborator

@adeebshihadeh do we keep the "850 support" id 348 or drop it?

Sorting, missing GPIO and msm-id defines.

Signed-off-by: David Heidelberg <david@ixit.cz>
@okias okias force-pushed the mainline-coding-style branch from 4158e1a to d334e52 Compare June 23, 2026 12:50
@adeebshihadeh

Copy link
Copy Markdown
Contributor

@adeebshihadeh do we keep the "850 support" id 348 or drop it?

We need to keep it

@okias

okias commented Jun 23, 2026

Copy link
Copy Markdown
Author

@adeebshihadeh it's SDA850 without modem or SDM850 with?

@adeebshihadeh

adeebshihadeh commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

it’s a binned SDA845 used for laptops

@okias okias force-pushed the mainline-coding-style branch from d334e52 to 5d7e901 Compare June 23, 2026 18:52
@okias

okias commented Jun 23, 2026

Copy link
Copy Markdown
Author

sent to upstream as https://lore.kernel.org/linux-arm-msm/20260623-sda850-v1-1-ddd8e62c85d8@ixit.cz/T/#u until bumped or this patch gets included in the tree, I kept it as is here and removed the last patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants