Duplicate #892 - Rails 6 save stack too deep on File upload#899
Merged
Conversation
Contributor
Author
|
Pinging @morgant for eyes |
|
Is something holding this up? We've moved to Rails 6 and can confirm this fix solves the recursive ActiveStorage file upload problem. |
Contributor
Contributor
Author
Member
|
Thanks! Sorry about my inactivity. I'll try to clean up stuff and do a gem release by the end of the month. |
Contributor
|
Thanks @GBH! |
This was referenced Dec 9, 2019
gr8bit
added a commit
to bichinger/comfortable-mexican-sofa
that referenced
this pull request
Mar 31, 2022
…a into bichinger * 'master' of github.com:bichinger/comfortable-mexican-sofa: fix seeds exporter (comfy#911) Bump comfortable_mexican_sofa to 2.0.19 fixing issue with rack 2.0.8 will this works with sprokets 4? syncing locale files feat(I18n): added arabic locale (comfy#897) bumping puma bumping sqlite gem rails 6 needs ruby 2.5+ wip getting things not crash in for rails 6 Duplicate comfy#892 - Rails 6 save stack too deep on File upload (comfy#899) bug with when there are no pages updating test matrix # Conflicts: # Gemfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All credit goes to @tongboy: #892
PR is failing simple specs that just need to be rebase. No movement has been had for 2 weeks.
Feel free to close if primary PR regains activity.
PR Fixes this issue: #898