Redactor 3#886
Open
gr8bit wants to merge 18 commits into
Open
Conversation
…r 3 version upgrade
…a into redactor-3 * 'master' of github.com:bichinger/comfortable-mexican-sofa: (24 commits) should not need to manually start service updating readme. trying to get travis working againg gotta make it available in the list fixing problem with seed rake task added support for hr locale adding readme about version 1 working on rails 5.2 coppers reworked options_for_select a bit Fix default classes for comfy cms seeds import and export task (comfy#878) Bump comfortable_mexican_sofa to 2.0.18 fix so ci runs files require labels cleaning up file label setter a bit fixing link to the variant bumping travis rubys just deleted all lines previously commented out fix for variant url remove the pry remove trailing spaces correct typo on function name ...
…g to absence of console log access
Contributor
Author
|
I just noticed this HowTo for a Reactor upgrade: I did not see this before, sorry. We'll have to go through that as well I guess. |
Contributor
Author
|
@GBH fyi: we'll be using it in a project, so we're currently fixing everything that the update broke. :) |
Member
|
@gr8bit 👍 Rails 6 final release probably will happen this fall. I'll jump in sometimes then to merge everything in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tests succeed, even the system/capybara tests (well, most of the time. Racing conditions seem to be racing).
Biggest changes for version 3 of Redactor (please review @GBH, I don't know if this breaks something):
Let's finalize this together @GBH :) Do you have a real world project we can throw this into?