Revert mill init bloated dependencies and fix SpringBootModule reflection (-parameters)#7265
Open
vaslabs wants to merge 4 commits into
Open
Revert mill init bloated dependencies and fix SpringBootModule reflection (-parameters)#7265vaslabs wants to merge 4 commits into
vaslabs wants to merge 4 commits into
Conversation
Contributor
Author
|
@souvlakias please check I haven't accidentally reverted your quarkus work or anything else |
Contributor
All good 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7197
On the broken examples mentioned in the reverting PR see:
mill initBloated build files in SpringBoot migration #7197 (comment)mill initBloated build files in SpringBoot migration #7197 (comment)Also fixes #7268 by having a default
-parametersfor javacOptions in SpringBootModuleOther
Also updated the spring boot docs with a few lines to mention some features
SpringBootModulebrings out of the box (including the new addition with the-parameterscompiler option)