Make solr field/schema resolvers respect the tokenized field of attributes#7003
Open
clockard wants to merge 2 commits into
Open
Make solr field/schema resolvers respect the tokenized field of attributes#7003clockard wants to merge 2 commits into
clockard wants to merge 2 commits into
Conversation
|
chris.lockard seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
jrnorth
reviewed
Jun 2, 2026
jaymcnallie
requested changes
Jun 2, 2026
Member
jaymcnallie
left a comment
There was a problem hiding this comment.
Trying to figure out why the unit tests lit up red on the PR build. I think you introduced a query side regression by selectively writing the tokenized copy of the attribute data.
Queries also need to respect the tokenized/not-tokenized field behavior when they run. As it stands, fuzzy searches will look in tokenized fields for tokenized=false attributes and never get results because those fields are now empty.
jaymcnallie
requested changes
Jun 4, 2026
d2c89f0 to
2981850
Compare
jaymcnallie
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the solr resolvers to respect the tokenized field of attribute definitions instead of assuming all text fields are tokenized.
Also makes metacard-tags tokenized.
One question I still have is why wildcard id queries don't work in the testing framework. By default the solr schema does have id defined as tokenized but that's not how the attribute is defined. It should work either way but it wasn't in the tests which is why I had to switch them to anyText filters.
Who is reviewing it?
@jaymcnallie
@jrnorth
Any background context you want to provide?
The default ddf solr schema uses primarily dynamic field definitions. These definitions determine how solr stores/handles the data and completely disregards the MetacardType definitions of attributes when it comes to fields like indexed and tokenized. If a downstream project wants to define their fields explicitly for better data handling the resolvers assumption of all string fields being tokenized breaks down and causes issues.
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: