Preserve the wording each comment refers to - #2456
Merged
Merged
Conversation
Editing text after a comment was written left the conversation without a point of reference: nothing showed what the wording had been when someone objected to it. Longer threads made this worse, since later replies can refer to yet another intermediate version. Each comment now keeps the wording it responded to and shows it once the text has changed, so threads stay readable after the fact. Comments on text that still reads the same show nothing, leaving the common case as compact as before. Available for text blocks, where a comment covers a selected range, and for headings, where it covers the whole element. Comments written earlier have no recorded wording and show none. REDMINE-21261
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing text after a comment was written left the conversation without a point of reference: nothing showed what the wording had been when someone objected to it. Longer threads made this worse, since later replies can refer to yet another intermediate version.
Each comment now keeps the wording it responded to and shows it once the text has changed, so threads stay readable after the fact. Comments on text that still reads the same show nothing, leaving the common case as compact as before.
Available for text blocks, where a comment covers a selected range, and for headings, where it covers the whole element. Comments written earlier have no recorded wording and show none.
REDMINE-21261