Implement docstring, missing methods, basic streaming#56
Conversation
| key (bytes): Key to retrieve | ||
| offset (int): Offset of history | ||
| limit (int): Limit of history entries | ||
| sortorder (bool): Sort order of history |
There was a problem hiding this comment.
Please add information what True and False mean here.
There was a problem hiding this comment.
I've resolved this with a documentation change, but I also opened a PR against this branch with a change to the method that resolves the confusion: #59
There was a problem hiding this comment.
I commented in #59
We shouldn't introduce new parameter, but just rename first one if we really want to do it. Or just write it in the documentation
NickAnderegg
left a comment
NickAnderegg
left a comment
There was a problem hiding this comment.
Most of the outstanding discussion points have been resolved by my recent commits, but I have a few open points marked in this review that need clarification.
| Args: | ||
| cleanupPercentage (float): Indicates the percentage of the | ||
| storage space that will be scanned for unreference data. Although | ||
| this operation blocks transaction processing, choosing a small | ||
| value (e.g. ``0.1``) may not significantly hinder normal operations, | ||
| and will reduce used storage space. |
There was a problem hiding this comment.
This is a percentage from 0 to 1, correct? If so, then it should be phrased this way instead:
| Args: | |
| cleanupPercentage (float): Indicates the percentage of the | |
| storage space that will be scanned for unreference data. Although | |
| this operation blocks transaction processing, choosing a small | |
| value (e.g. ``0.1``) may not significantly hinder normal operations, | |
| and will reduce used storage space. | |
| Args: | |
| cleanupPercentage (float): Fractional decimal indicating the percentage of the | |
| storage space that will be scanned for unreferenced data. Although | |
| this operation blocks transaction processing, choosing a small | |
| value (e.g. ``0.1``) may not significantly hinder normal operations, | |
| and will reduce used storage space. |
There was a problem hiding this comment.
Nope, this is between 0 and 100, the 0.1 value is really 0.1% (which is a sane value in this case)
| key (bytes): Key to retrieve | ||
| offset (int): Offset of history | ||
| limit (int): Limit of history entries | ||
| sortorder (bool): Sort order of history |
There was a problem hiding this comment.
I've resolved this with a documentation change, but I also opened a PR against this branch with a change to the method that resolves the confusion: #59
| Args: | ||
| user (str): username | ||
| newPassword (str): new password | ||
| oldPassword (str): old password |
There was a problem hiding this comment.
What is it that's only necessary for the sysadmin user?
| Args: | ||
| user (str): username | ||
| newPassword (str): new password | ||
| oldPassword (str): old password |
There was a problem hiding this comment.
This are restrictions implied by the immudb itself.
SysAdmin can change his own password only by giving old and new password.
SysAdmin user can change password of any other user without old password.
Admin users can change password for user only created by that admin without old password.
…-py into feature/fullapisupport
5 participants
All methods implemented