Skip to content

Fixed duplicate columns removing data from CSV #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julesyan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed duplicate columns removing data from CSV #542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 34 additions & 6 deletions src/views/results/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,8 @@ async function runHandler(options?: StatementInfo) {

setCancelButtonVisibility(true);
updateStatusBar({ executing: true });
const data = await JobManager.runSQL(statementDetail.content);
const result = await JobManager.runSQLVerbose(statementDetail.content);
const data = result.data;
setCancelButtonVisibility(false);

if (data.length > 0) {
Expand All @@ -491,11 +492,38 @@ async function runHandler(options?: StatementInfo) {
let content = ``;
switch (statementDetail.qualifier) {
case `csv`:
content = csv.stringify(data, {
header: true,
quoted_string: true,
delimiter: DelimValue[Configuration.get<string>(`codegen.csvColumnDelimiter`) || `Comma`]
});
// Use metadata to handle duplicate column names properly
if (result.metadata && result.metadata.columns) {
const delimiter = DelimValue[Configuration.get<string>(`codegen.csvColumnDelimiter`) || `Comma`];
const columnNames = result.metadata.columns.map(col => col.name);

// Build CSV manually to preserve duplicate column names
const rows: string[][] = [];

// Add header row
rows.push(columnNames.map(name => `"${String(name).replace(/"/g, '""')}"`));

// Add data rows - use column index to get values in correct order
for (const row of data) {
const values = columnNames.map(name => {
const value = row[name];
if (value === null || value === undefined) {
return '';
}
return `"${String(value).replace(/"/g, '""')}"`;
});
rows.push(values);
}

content = rows.map(row => row.join(delimiter)).join('\n');
} else {
// Fallback to original method if no metadata
content = csv.stringify(data, {
header: true,
quoted_string: true,
delimiter: DelimValue[Configuration.get<string>(`codegen.csvColumnDelimiter`) || `Comma`]
});
}
break;
case `json`: content = JSON.stringify(data, null, 2); break;

Expand Down
Loading