DOC-17055: Remove cockroach PR/commit links from release notes#23301
Open
ebembi-crdb wants to merge 4 commits into
Open
DOC-17055: Remove cockroach PR/commit links from release notes#23301ebembi-crdb wants to merge 4 commits into
ebembi-crdb wants to merge 4 commits into
Conversation
Unlink 287 release note files by converting markdown references like [#85177][#85177] to plain #85177 text. These links pointed to PRs and commits in the cockroach repo that are not useful references for users reading release notes. Part of DOC-17055. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
4 tasks
Resolve conflicts in v26.2 release note files where main added new entries. Keep main's content with PR links stripped per this branch's purpose. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Files changed:
|
|
✅ Cross-Version Link Check Passed All cross-version link issues have been resolved. Good job! |
Replace hardcoded version paths with {{ page.version.version }} in
10 release note files to fix CI cross-version link check.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Release note includes don't have page.version.version available. Revert cross-version links to use each file's own version instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rmloveland
reviewed
May 21, 2026
| - Added a new session variable `allow_role_memberships_to_change_during_transaction` which can be used to make the [granting]({% link v23.1/grant.md %}) and [revoking]({% link v23.1/revoke.md %}) of [role memberships](https://www.cockroachlabs.com/docs/v23.1/security-reference/authorization#roles) faster at the cost of some [isolation](https://www.cockroachlabs.com/docs/v23.1/architecture/transaction-layer#isolation-levels) claims. By default, when granting or revoking a role from another role, CockroachDB waits for all [transactions]({% link v23.1/transactions.md %}) that are consulting the current set of role memberships to complete. This means that by the time the transaction which performed the grant or revoke operation returns successfully, the user has a proof that no ongoing transaction is relying on the state that existed prior to the change. The downside of this waiting is that it means that `GRANT` and `REVOKE` will take longer than the longest currently executing transaction. In some cases, users do not care about whether concurrent transactions will immediately see the side-effects of the operation, and would instead prefer that the grant or revoke finish rapidly. In order to aid in those cases, the session variable `allow_role_memberships_to_change_during_transaction` has been added. Now, the grant or revoke will only need to wait for the completion of statements in [sessions]({% link v23.1/show-sessions.md %}) which do not have this option set. One can set the option as enabled by default in all sessions in order to accelerate and grant and revoke role operations. [#98370][#98370] | ||
| - Fixed a bug where CockroachDB panicked when a user tried to [truncate a table]({% link v23.1/truncate.md %}) which had an ongoing [Row-level TTL]({% link v23.1/row-level-ttl.md %}) change. CockroachDB still does not support truncating a table in this scenario, but instead of panicking an "unimplemented" error is returned. [#98537][#98537] | ||
| - A regions field was added to the `statistics` column of [`crdb_internal.statement_statistics`](https://www.cockroachlabs.com/docs/v23.1/crdb-internal#statement_statistics), reporting the [regions]({% link v23.1/show-regions.md %}) of the nodes on which the statement was executed. #95449 | ||
| - The `enforce_home_region` [session setting]({% link v23.1/set-vars.md %}#enforce-home-region) was extended with a new optional preview feature and session setting, which is disabled by default, to dynamically detect and report the home region for [`SELECT`]({% link v23.1/selection-queries.md %}) queries based on the [locality]({% link v23.1/show-locality.md %}) of the queried rows, if different from the region of the [gateway node]({% link v23.1/ui-sessions-page.md %}#session-details-gateway-node). [cockroachdb/cockroach#97827]#97827 |
Contributor
There was a problem hiding this comment.
there are several instances of malformed links like this one: [cockroachdb/cockroach#97827]#97827 - please fix this and the others (should be a mechanical regex over the PR)
Contributor
There was a problem hiding this comment.
here are the other instances found by Codex in this PR for reference:
- src/current/_includes/releases/v23.1/v23.1.0-alpha.7.md:27 - #97827
- src/current/_includes/releases/v23.1/v23.1.0-alpha.7.md:33 - #98217
- src/current/_includes/releases/v23.1/v23.1.0-alpha.7.md:45 - #98543
- src/current/_includes/releases/v23.1/v23.1.0-alpha.7.md:68 - #98312
- src/current/_includes/releases/v23.1/v23.1.0-alpha.7.md:71 - #97138
- src/current/_includes/releases/v23.1/v23.1.0-alpha.7.md:79 - #97948
- src/current/_includes/releases/v23.1/v23.1.0-alpha.7.md:82 - #98307
- src/current/_includes/releases/v23.1/v23.1.0-alpha.7.md:99 - #98261
- src/current/_includes/releases/v23.2/v23.2.12.md:26 - #130712
- src/current/_includes/releases/v23.2/v23.2.12.md:37 - #128864
- src/current/_includes/releases/v24.1/v24.1.2.md:20 - #125554
- src/current/_includes/releases/v24.2/v24.2.0-beta.2.md:28 - #127364
rmloveland
reviewed
May 21, 2026
| - Fixed a bug where [changefeeds]({% link v23.1/change-data-capture-overview.md %}) would fail when upgrading to version [v23.1.5](#v23-1-5) because the job record did not have a `clusterID` field set. #106399 | ||
| - Fixed a bug where `UPDATE`, `UPSERT`, `DELETE` statements running concurrently with [`ALTER TABLE..ADD COLUMN`]({% link v23.1/alter-table.md %}#add-column) of a virtual computed column on the same table would fail. #107403 | ||
| - Fixed a bug where [SQL statistics compaction jobs]({% link v23.1/show-jobs.md %}#show-automatic-jobs) would fail. This is now fixed by reducing the contention on the `system.statement_statistics` table. #107573 | ||
| - Fixed a bug where running a [changefeed]({% link v23.1/change-data-capture-overview.md %}) that targets a table with a user-defined type column and with the [`envelope` option]({% link v23.1/create-changefeed.md %}#envelope) set to any value other than `wrapped` would cause a node panic due to a nil dereference. [#119746][119746] |
Contributor
There was a problem hiding this comment.
this still uses the old [#xxx][#xxx] format - please update so it's plain text #xxx like the other PR IDs
rmloveland
approved these changes
May 21, 2026
Contributor
rmloveland
left a comment
rmloveland
left a comment
There was a problem hiding this comment.
LGTM once you fix the few link formatting issues i mentioned! thanks @ebembi-crdb !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[#85177][#85177]to plain#85177textThis is PR 1 of 10 splitting #23256 into reviewable chunks.
Jira: DOC-17055
Test plan
[#NNNNN][#NNNNN]patterns in release note includes🤖 Generated with Claude Code