Skip to content

[NGT] Bug fix for tau prevalidation sequence in Run2 workflow#51198

Open
elenavernazza wants to merge 1 commit into
cms-sw:masterfrom
cms-ngt-hlt:BugFixTauValidation
Open

[NGT] Bug fix for tau prevalidation sequence in Run2 workflow#51198
elenavernazza wants to merge 1 commit into
cms-sw:masterfrom
cms-ngt-hlt:BugFixTauValidation

Conversation

@elenavernazza

Copy link
Copy Markdown
Contributor

PR description:

This PR fixes a failure observed in workflow 1311.0, caused by missing products needed to build the generator-level tau collection used in the new tau validation strategy introduced in #51092.

The issue manifests as a ProductNotFound exception during the prevalidation_step, when the module tauGenJetsSelectorAllHadrons attempts to access the tauGenJets collection:

----- Begin Fatal Exception 11-Jun-2026 05:53:51 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 2 stream: 3
   [1] Running path 'prevalidation_step'
   [2] Calling method for module TauGenJetDecayModeSelector/'tauGenJetsSelectorAllHadrons'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::io_v1::GenJet>
Looking for module label: tauGenJets
Looking for productInstanceName: 
----- End Fatal Exception -------------------------------------------------

The cause is the missing tauGenJets collection, which is not produced in the Run-2 validation workflow. The tauGenJetsSelectorAllHadrons sequence is now restricted to Phase-2 workflows only, where the necessary inputs are available. This restores correct behavior of the tau validation, including the DQM plots introduced in #51092.

PR validation:

The fix has been validated in:

  • Affected Run-2 workflow: 1311.0 (now runs without errors)
  • Phase-2 workflow: 34434.0 (tau validation behaves as expected)

It has also been tested on TenTau RelVal samples using the following commands:

  • Tau Validation (HLT only):
cmsDriver.py step2 -s L1P2GT,HLT:75e33,VALIDATION:@hltValidation -n -1 --nThreads 0 \
 --conditions auto:phase2_realistic_T35 --datatier GEN-SIM-DIGI-RAW,DQMIO \
 --customise SLHCUpgradeSimulations/Configuration/aging.customise_aging_1000 --eventcontent FEVTDEBUGHLT,DQMIO \
 --geometry ExtendedRun4D110 --era Phase2C17I13M9 --hltProcess HLTX --processName HLTX \
 --filein file:/eos/cms/store/relval/CMSSW_20_0_0_pre1/RelValTenTau_15_500/GEN-SIM-DIGI-RAW/150X_mcRun4_realistic_v1_STD_RegeneratedGS_D121_noPU-v1/2590000/390470c8-1a6f-4259-8e96-561dde76396b.root --fileout file:step2.root \
 --inputCommands="keep *, drop *_hlt*_*_HLT, drop triggerTriggerFilterObjectWithRefs_l1t*_*_HLT"
cmsDriver.py step3 -s HARVESTING:@hltValidation -n -1 \
 --conditions auto:phase2_realistic_T35 --mc --geometry ExtendedRun4D110 --era Phase2C17I13M9 \
 --filetype DQM --scenario pp --hltProcess HLTX --filein file:step2_inDQM.root --fileout file:step3.root
  • Tau Validation (HLT + RECO):
cmsDriver.py step3 -s RAW2DIGI,RECO,RECOSIM,PAT,VALIDATION:@phase2Validation -n 10 \
 --conditions auto:phase2_realistic_T35 --geometry ExtendedRun4D110 --era Phase2C17I13M9 \
 --datatier DQMIO --eventcontent DQM \
 --customise SLHCUpgradeSimulations/Configuration/aging.customise_aging_1000 \
 --customise_command "process.globalValidationHCAL = cms.Sequence(process.hcalSimHitsValidationSequence + process.hcalSimHitStudy)" \
 --filein file:/eos/cms/store/relval/CMSSW_20_0_0_pre1/RelValTenTau_15_500/GEN-SIM-DIGI-RAW/150X_mcRun4_realistic_v1_STD_RegeneratedGS_D121_noPU-v1/2590000/390470c8-1a6f-4259-8e96-561dde76396b.root \
 --fileout file:step3.root 
cmsDriver.py step4 -s HARVESTING:@phase2Validation -n -1 \
 --conditions auto:phase2_realistic_T35 --mc --geometry ExtendedRun4D110 --era Phase2C17I13M9 \
 --filetype DQM --scenario pp --hltProcess HLTX --filein file:step3.root --fileout file:step4.root

@cmsbuild

cmsbuild commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51198/49722

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @elenavernazza for master.

It involves the following packages:

  • HLTriggerOffline/Common (dqm)
  • Validation/Configuration (dqm, simulation)
  • Validation/RecoTau (dqm)

@civanch, @cmsbuild, @ctarricone, @gabrielmscampos, @kpedro88, @mdhildreth, @rseidita can you please review it and eventually sign? Thanks.
@apsallid, @denizsun, @missirol, @mmusich, @mtosi, @rovere, @salimcerci this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich

mmusich commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

type bug-fix, ngt

@mmusich

mmusich commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

test parameters:

  • workflows = ph2_hlt, 11.0, 281.0, 1311.0

@mmusich

mmusich commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@cmsbuild, please test

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5459d8/53857/summary.html
COMMIT: 6a572a4
CMSSW: CMSSW_20_1_X_2026-06-10-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51198/53857/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
11.0 step 3
1311.0 step 3
281.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 523 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 57
  • DQMHistoTests: Total histograms compared: 3688981
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3688963
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.008 KiB( 56 files compared)
  • DQMHistoSizes: changed ( 18434.0 ): -0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 18434.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 251 log files, 208 edm output root files, 57 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants