Skip to content

Fix separate option in HGCAL validation#51168

Open
bfonta wants to merge 6 commits into
cms-sw:masterfrom
bfonta:feature/separate_plots
Open

Fix separate option in HGCAL validation#51168
bfonta wants to merge 6 commits into
cms-sw:masterfrom
bfonta:feature/separate_plots

Conversation

@bfonta

@bfonta bfonta commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

The --separate option of the makeHGCalValidationPlots.py script was crashing. I fixed the "bug" (AFAICT the usage of multiple TCanvas with the same name) and took the chance to remove some duplicated code and apply other minor improvements.
The --separate version, on top of separating plots to independent canvases, now produces the PNG plots directly into the folder structure, without the html wrapping (so partially mimicking what the --no_html option is doing).
The default options were left unchanged.

Tested with and without the --separate option:

python3 Validation/HGCalValidation/scripts/makeHGCalValidationPlots.py DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO.root -o /eos/user/b/bfontana/www/SinglePhotonTESTS/HGCALValidation/ --collections tracksters

python3 Validation/HGCalValidation/scripts/makeHGCalValidationPlots.py DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO.root -o /eos/user/b/bfontana/www/SinglePhotonTESTS/HGCALValidation/ --collections tracksters --separate

@bfonta

bfonta commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

type ngt

@cmsbuild

cmsbuild commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

cmsbuild commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51168/49688

@cmsbuild

cmsbuild commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @bfonta for master.

It involves the following packages:

  • Validation/HGCalValidation (dqm)
  • Validation/RecoTrack (dqm)

@cmsbuild, @ctarricone, @gabrielmscampos, @rseidita can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @apsallid, @bsunanda, @cseez, @denizsun, @dgulhan, @elusian, @felicepantaleo, @hatakeyamak, @lecriste, @lgray, @mmasciov, @mmusich, @mtosi, @pfs, @rovere, @salimcerci, @sethzenz, @vandreev11, @wmtford this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich

mmusich commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@cmsbuild, please test

@cmsbuild

cmsbuild commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 72KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ccb6f3/53797/summary.html
COMMIT: 11df309
CMSSW: CMSSW_20_1_X_2026-06-09-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51168/53797/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3482189
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3482171
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 199 log files, 169 edm output root files, 46 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants