Skip to content

Fix finding operator<< for reco::io_v1::PFTau#51134

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
Dr15Jones:fixPFTauPrint
Jun 8, 2026
Merged

Fix finding operator<< for reco::io_v1::PFTau#51134
cmsbuild merged 1 commit into
cms-sw:masterfrom
Dr15Jones:fixPFTauPrint

Conversation

@Dr15Jones

@Dr15Jones Dr15Jones commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

PR description:

Needs to be defined in the reco::io_v1 namespace.

PR validation:

Building in CMSSW_20_0_DBG_X_2026-06-05-2300 now avoids the link error seen in the equivalent IB.

The change is purely technical.

resolves cms-sw/framework-team#2272

Needs to be defined in the reco::io_v1 namespace.
@Dr15Jones

Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild

cmsbuild commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

cmsbuild commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

@cmsbuild

cmsbuild commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • DataFormats/TauReco (reconstruction)

@Moanwar, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@azotz, @mbluj, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones

Copy link
Copy Markdown
Contributor Author

Please test

@Dr15Jones

Copy link
Copy Markdown
Contributor Author

type bug

@Dr15Jones

Copy link
Copy Markdown
Contributor Author

@cms-sw/reconstruction-l2 @cms-sw/orp-l2 @makortel this would be good to get into CMSSW_20 as it corrects a problem caused by the migration to the io_v1 namespace that is only seen in the DBG build.

@cmsbuild

cmsbuild commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-100ba3/53707/summary.html
COMMIT: bbbf57c
CMSSW: CMSSW_17_0_X_2026-06-06-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51134/53707/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-100ba3/53707/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-100ba3/53707/git-merge-result

Failed RelVals

ValueError: Undefined workflows: 10224.0, 250202.181, 25202.0

@Dr15Jones

Copy link
Copy Markdown
Contributor Author

Please test

@cmsbuild

cmsbuild commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-100ba3/53727/summary.html
COMMIT: bbbf57c
CMSSW: CMSSW_20_0_X_2026-06-08-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51134/53727/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3248390
  • DQMHistoTests: Total failures: 64
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248308
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 159 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild

cmsbuild commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit b779e38 into cms-sw:master Jun 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix finding operator<< for reco::io_v1::PFTau

3 participants