[Phase2 L1T] GMT Upgrade of Kalman Filter for Barrel Muon KMTF by zhenbinwu · Pull Request #51111 · cms-sw/cmssw

zhenbinwu · 2026-06-01T21:44:09Z

PR description:

Extend the Kalman Muon Barrel Track Finding algorithm for more precise measurements of track eta and z
Making use of new dataformat of Phase2 DT, Phi-Theta matched pairs
Detail in talk

PR validation:

Ongoing ...

KMTFTrack now requires z, kSlope as arguments added z, kSlope members and accessors setCoordinates, setCovariance now require arguments z, kSlope

…new gain LUTs now for z, kSlope

cmsbuild · 2026-06-01T21:44:51Z

cms-bot internal usage

cmsbuild · 2026-06-01T21:46:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51111/49609

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/L1TMuonPhase2/src/classes_def.xml modified in PR(s): Move stored types in io_v1 namespace, reset class versions to 3 #50968

cmsbuild · 2026-06-01T21:46:39Z

A new Pull Request was created by @zhenbinwu for master.

It involves the following packages:

DataFormats/L1TMuonPhase2 (l1)
L1Trigger/Phase2L1GMT (l1)

@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @eyigitba, @missirol, @mmusich, @rovere, @thomreis this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

quinnanm · 2026-06-02T01:03:05Z

please test

cmsbuild · 2026-06-02T03:04:42Z

+1

Size: This PR adds an extra 692KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-911f60/53636/summary.html
COMMIT: 6782bb3
CMSSW: CMSSW_17_0_X_2026-06-01-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51111/53636/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 3 lines from the logs
Reco comparison results: 16 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4199113
DQMHistoTests: Total failures: 392
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4198701
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: found differences in 3 / 51 workflows

cmsbuild · 2026-06-05T16:38:22Z

Milestone for this pull request has been moved to CMSSW_20_0_X. Please open a backport if it should also go in to CMSSW_17_0_X.

makortel · 2026-06-05T18:19:04Z

(I assume this PR does not need a backport to 17_0_X (Run 3 legacy))

makortel · 2026-06-05T18:21:11Z

+    <version ClassVersion="5" checksum="251130338"/>
+    <version ClassVersion="4" checksum="251130338"/>


Only one new class version should be added. Very likely you also need to rebase on top of 20_0_0_pre1 (hopefully available early next week) because the checksum for version 3 will be changed for that.

BenjaminRS · 2026-06-05T21:16:41Z

HI Matti - indeed this is a Phase 2 only algorithm for 20_1_X

quinnanm

Thank you for this PR! Just a few minor comments.

quinnanm · 2026-06-09T00:06:41Z

 int KMTFCore::customBitmask(unsigned int bit1, unsigned int bit2, unsigned int bit3, unsigned int bit4) {
  return bit1 * 1 + bit2 * 2 + bit3 * 4 + bit4 * 8;
 }

 bool KMTFCore::getBit(int bitmask, int pos) { return (bitmask & (1 << pos)) >> pos; }

 void KMTFCore::setFourVectors(l1t::KMTFTrack& track) {
-  int etaINT = track.coarseEta();
+  //int etaINT = track.coarseEta();
+  ap_ufixed<18, 0> m = 0.03602;


could you maybe add a comment adding context to these numbers?

quinnanm · 2026-06-09T00:07:13Z

@@ -745,7 +1045,7 @@ bool KMTFCore::updateLUT(l1t::KMTFTrack& track, const l1t::MuonStubRef& stub, in
                               << ap_ufixed<GAIN2_5, GAIN2_5INT>(GAIN[3]).to_float();
  }

-  track.setKalmanGain(track.step(), fabs(trackK), GAIN[0], GAIN[1], 1, 0, GAIN[2], GAIN[3]);
+  //track.setKalmanGain(track.step(), fabs(trackK), GAIN[0], GAIN[1], 1, 0, GAIN[2], GAIN[3]);


can this comment be deleted?

quinnanm · 2026-06-09T00:15:39Z

@@ -1086,7 +1464,7 @@ int KMTFCore::encode(bool ownwheel, int sector, int tag) {

 std::pair<bool, uint> KMTFCore::getByCode(const std::vector<l1t::KMTFTrack>& tracks, int mask) {
  for (uint i = 0; i < tracks.size(); ++i) {
-    edm::LogInfo("KMTFCore") << "Code=" << tracks[i].hitPattern() << ", track=" << mask;
+    //edm::LogInfo("KMTFCore") << "Code=" << tracks[i].hitPattern() << ", track=" << mask;


can this comment be deleted?

quinnanm · 2026-06-09T00:16:44Z

is this the intended location of this file or is it planned to live elsewhere like cms-data?

quinnanm · 2026-06-09T00:22:36Z

    TFile *lutFile_;
+    TFile *lutThetaFile_;


should these be std::unique_ptr<TFile>?

quinnanm · 2026-06-09T00:23:31Z

+  const auto& phiS = pairs.phiDigi();
+  static constexpr int ZCenterDigitizedPositive[] = {11730, 23327};
+  static constexpr int ZCenterDigitizedNegative[] = {-11697, -23290};
+  static constexpr int ZCenterDigitizedZero[] = {22};


this is a bit odd as a single element array rather than a constexpr int but if you really like it this way I guess it's fine

quinnanm · 2026-06-09T00:26:22Z

@@ -110,12 +134,51 @@ namespace Phase2L1GMT {
      return uint((1 << 12) * coarseEta_->GetBinContent(coarseEta_->GetXaxis()->FindBin(mask)) / M_PI);
    }

+    std::vector<float> trackGainTheta(uint step, uint bitmask, uint K, bool is2D) {


could this be const? likewise the trackGainTheta2 getter

cmsbuild · 2026-06-09T07:28:41Z

Milestone for this pull request has been moved to CMSSW_20_1_X. Please open a backport if it should also go in to CMSSW_20_0_X.

delanocamposs added 30 commits February 27, 2026 19:57

Merged AMv2.3 from repository jfernan2 with cms-merge-topic

7f7c6b0

bitshift bug fix KMTF.cc

a99796d

New typedef for 5 dimensional covariance matrix

584d706

KMTFTrack now requires z, kSlope as arguments added z, kSlope members and accessors setCoordinates, setCovariance now require arguments z, kSlope

new class version for KMTFTrack.h update version 4.

76a32a8

initial development commits

e98e4a9

symmetrix matrix fix

e514aeb

matrix vector fix

e5b0f3c

revert matrix vector argument to upper triangle only

afc1d61

verbose = 1

edee2c8

testing new z prop wheel-based logic

d62af54

more verbose print statements

8ed52d9

printout changes

e84f5c7

fix initial covariances

2c29220

kSlope point resolution

4b648c6

previous propagation residuals

93259fa

latest

d9dbe79

reverting back to using kSlope in measurement space for residual

63e041e

tests

1c15a25

testing

13ff919

testing

629bb34

updates

2172930

add new members and accessors for new gain values

3bc97b4

fixed point arithmetic for zNew and kSlope. updateLUT function pulls …

66d9d59

…new gain LUTs now for z, kSlope

packed gain theta view LUT root file

fc06842

small cleanup

a04c22f

cleanup printouts

a40c085

fix wraparound bug

51bb165

5D vertex constraint offline/LUT updates

044560b

kSlopeNew fixed point arithmetic computation

2992c40

Barrel Stub Processor cleanup

3b34903

cmsbuild added code-checks-pending changes-dataformats labels Jun 1, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 1, 2026

cmsbuild added tests-started and removed tests-pending labels Jun 2, 2026

cmsbuild added tests-approved and removed tests-started labels Jun 2, 2026

cmsbuild modified the milestones: CMSSW_17_0_X, CMSSW_20_0_X Jun 5, 2026

makortel reviewed Jun 5, 2026

View reviewed changes

quinnanm reviewed Jun 9, 2026

View reviewed changes

cmsbuild modified the milestones: CMSSW_20_0_X, CMSSW_20_1_X Jun 9, 2026

zhenbinwu mentioned this pull request Jun 10, 2026

Add LUT for Kalman algo of KMTF cms-data/L1Trigger-Phase2L1GMT#2

Open

		<version ClassVersion="5" checksum="251130338"/>
		<version ClassVersion="4" checksum="251130338"/>

Conversation

zhenbinwu commented Jun 1, 2026

PR description:

PR validation:

Uh oh!

cmsbuild commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jun 1, 2026

Uh oh!

cmsbuild commented Jun 1, 2026

Uh oh!

quinnanm commented Jun 2, 2026

Uh oh!

cmsbuild commented Jun 2, 2026

Comparison Summary

Uh oh!

cmsbuild commented Jun 5, 2026

Uh oh!

makortel commented Jun 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BenjaminRS commented Jun 5, 2026

Uh oh!

quinnanm left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cmsbuild commented Jun 1, 2026 •

edited

Loading