Phase2 L1T: Correlator development for AR2026 by cerminar · Pull Request #51093 · cms-sw/cmssw

cerminar · 2026-05-29T14:49:31Z

PR description:

Port recent Correlator development to master.

For now:

SeededCone-8 2-Prong Jet Model (L1TSC82ProngJetModel p2l1pfp/cmssw#150)
Unse TMUX18 Layer-1 configuration consistently across the emulation chain (Move default config to TMUX18 and drop TMUX6 modules for binary file creation p2l1pfp/cmssw#155)

PR validation:

Ongoing...

* Added nprong score to DataFormats. * Added L1TSC82ProngJet to DPGAnalysis. * Added L1TSC82ProngJetModel to L1Trigger/Phase2L1ParticleFlow * Fix for nprong tag. * Cleaned includes. * File renamed. * Removed comment from addPh2GTObjects(process) * fixes. * Reverted changes. * Removed cuts.. * Update L1Trigger/Phase2L1ParticleFlow/src/L1TSC82ProngJetID.cc Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update L1Trigger/Phase2L1ParticleFlow/plugins/L1TSC82ProngJetModelProducer.cc Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update DataFormats/L1TParticleFlow/src/jets.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * added values for minPt and maxEta. * Added std headers. * Added a check for fNParticles. * Update L1Trigger/Phase2L1ParticleFlow/python/l1pfJetMet_cff.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply CMSSW code-format --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

cmsbuild · 2026-05-29T14:50:01Z

cms-bot internal usage

cmsbuild · 2026-05-29T14:51:54Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51093/49576

There are other open Pull requests which might conflict with changes you have proposed:
- File DPGAnalysis/Phase2L1TNanoAOD/python/l1tPh2Nanotables_cff.py modified in PR(s): [Not to merge] Update L1TPh2 ntuple sequence and eventcontent #49477
- File DataFormats/L1TParticleFlow/interface/jets.h modified in PR(s): Move stored types in io_v1 namespace, reset class versions to 3 #50968
- File DataFormats/L1TParticleFlow/src/jets.cpp modified in PR(s): Move stored types in io_v1 namespace, reset class versions to 3 #50968

quinnanm · 2026-06-02T01:03:22Z

please test

cmsbuild · 2026-06-02T01:03:42Z

A new Pull Request was created by @cerminar for master.

It involves the following packages:

DPGAnalysis/Phase2L1TNanoAOD (l1, xpog)
DataFormats/L1TParticleFlow (l1)
L1Trigger/Phase2L1ParticleFlow (l1)

@BenjaminRS, @battibass, @ftorrresd, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2026-06-02T05:22:39Z

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f83587/53637/summary.html
COMMIT: 8f89e86
CMSSW: CMSSW_17_0_X_2026-06-01-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51093/53637/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

34434.911

----- Begin Fatal Exception 02-Jun-2026 04:02:26 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTriggerFinalPath'
   [2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
   [3] Calling method for module L1TCtL2EgProducer/'l1tLayer2EGElliptic'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: l1t::RegionalOutput<std::vector<l1t::TkElectron> >
Looking for module label: l1tLayer1BarrelElliptic
Looking for productInstanceName: L1TkElePerBoard

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

34434.0

----- Begin Fatal Exception 02-Jun-2026 03:53:38 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTriggerFinalPath'
   [2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
   [3] Calling method for module L1TCtL2EgProducer/'l1tLayer2EGElliptic'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: l1t::RegionalOutput<std::vector<l1t::TkElectron> >
Looking for module label: l1tLayer1BarrelElliptic
Looking for productInstanceName: L1TkElePerBoard

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

34434.75

----- Begin Fatal Exception 02-Jun-2026 03:54:03 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTriggerFinalPath'
   [2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
   [3] Calling method for module L1TCtL2EgProducer/'l1tLayer2EGElliptic'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: l1t::RegionalOutput<std::vector<l1t::TkElectron> >
Looking for module label: l1tLayer1BarrelElliptic
Looking for productInstanceName: L1TkElePerBoard

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

cmsbuild · 2026-06-05T16:38:11Z

Milestone for this pull request has been moved to CMSSW_20_0_X. Please open a backport if it should also go in to CMSSW_17_0_X.

makortel · 2026-06-05T18:26:36Z

(I assume this PR does not need a backport to 17_0_X (Run 3 legacy))

cerminar · 2026-06-08T13:59:44Z

(I assume this PR does not need a backport to 17_0_X (Run 3 legacy))

I am actually not sure: @quinnanm @BenjaminRS what is the release we target for the AR2026 studies?
Cheers!

BenjaminRS · 2026-06-08T19:44:10Z

Hi Matti and Gianluca - we will have this Phase 2 PR just going to 20_1_X.

quinnanm

Thank you for this PR! Just a few minor comments/questions

quinnanm · 2026-06-09T00:34:25Z

+    fIs_filled_.get()[i0] = 1;
+
+    float massCand = 0.13f;
+    if (abs(iParts[i0]->charge())) {


should this be std::abs

quinnanm · 2026-06-09T00:39:04Z

+  }
+}
+
+std::vector<float> L1TSC82ProngJetID::EvaluateNNFixed() {


this is defined as a vector but returns a single float value, probably to be consistent with similar definitions?

quinnanm · 2026-06-09T00:43:11Z

+  const unsigned int NInputs = 160;
+  const unsigned int FeaturesPerParticle = 20;


should these be constexpr members of the class defined in the header? this may avoid magic numbers and add clarity to setNNVectorVar

quinnanm · 2026-06-09T00:44:08Z

@@ -0,0 +1,45 @@
+#ifndef L1TRIGGER_PHASE2L1PARTICLEFLOWS_L1TSC82ProngJetID_H
+#define L1TRIGGER_PHASE2L1PARTICLEFLOWS_L1TSC82ProngJetID_H
+


should L1TSC82ProngJetID be uppercase?

quinnanm · 2026-06-09T00:44:59Z

+  void setNNVectorVar();
+  std::vector<float> EvaluateNNFixed();


could these be const?

quinnanm · 2026-06-09T00:46:04Z

+    float massCand = 0.13f;
+    if (abs(iParts[i0]->charge())) {
+      if ((iParts[i0]->id() == l1t::PFCandidate::Muon)) {
+        massCand = 0.105;


could you add a comment adding context to this number?

quinnanm · 2026-06-09T00:47:51Z

+      if ((iParts[i0]->id() == l1t::PFCandidate::Muon)) {
+        massCand = 0.105;
+      } else if ((iParts[i0]->id() == l1t::PFCandidate::Electron)) {
+        massCand = 0.005;


likewise here: could you add a comment adding context to this number? likewise on L140 and L132

quinnanm · 2026-06-09T00:49:44Z

+#include "ap_fixed.h"
+#include "hls4ml/emulator.h"
+
+using namespace l1t;


could you use l1t::name rather than using namespace l1t?

cmsbuild · 2026-06-09T07:28:32Z

Milestone for this pull request has been moved to CMSSW_20_1_X. Please open a backport if it should also go in to CMSSW_20_0_X.

henripetrow and others added 2 commits May 29, 2026 11:25

TM18 is now the default configuration for all serenity modules

8f89e86

cmsbuild added this to the CMSSW_17_0_X milestone May 29, 2026

cmsbuild added l1-pending pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels May 29, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels May 29, 2026

cerminar marked this pull request as ready for review June 1, 2026 13:51

cmsbuild added tests-started and removed tests-pending labels Jun 2, 2026

cmsbuild added tests-rejected and removed tests-started labels Jun 2, 2026

cmsbuild modified the milestones: CMSSW_17_0_X, CMSSW_20_0_X Jun 5, 2026

quinnanm reviewed Jun 9, 2026

View reviewed changes

cmsbuild modified the milestones: CMSSW_20_0_X, CMSSW_20_1_X Jun 9, 2026

		const unsigned int NInputs = 160;
		const unsigned int FeaturesPerParticle = 20;

		@@ -0,0 +1,45 @@
		#ifndef L1TRIGGER_PHASE2L1PARTICLEFLOWS_L1TSC82ProngJetID_H
		#define L1TRIGGER_PHASE2L1PARTICLEFLOWS_L1TSC82ProngJetID_H

Conversation

cerminar commented May 29, 2026

PR description:

PR validation:

Uh oh!

cmsbuild commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented May 29, 2026

Uh oh!

quinnanm commented Jun 2, 2026

Uh oh!

cmsbuild commented Jun 2, 2026

Uh oh!

cmsbuild commented Jun 2, 2026

Failed RelVals

Uh oh!

cmsbuild commented Jun 5, 2026

Uh oh!

makortel commented Jun 5, 2026

Uh oh!

cerminar commented Jun 8, 2026

Uh oh!

BenjaminRS commented Jun 8, 2026

Uh oh!

quinnanm left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cmsbuild commented May 29, 2026 •

edited

Loading