cms-sw · smuzaffar · May 22, 2026 · Mar 18, 2026 · May 19, 2026 · May 20, 2026
diff --git a/CalibCalorimetry/EcalLaserAnalyzer/plugins/EcalTestPulseAnalyzer.cc b/CalibCalorimetry/EcalLaserAnalyzer/plugins/EcalTestPulseAnalyzer.cc
@@ -288,7 +288,6 @@ void EcalTestPulseAnalyzer::analyze(const edm::Event& e, const edm::EventSetup&
   double chi2pn = 0;
   double ypnrange[50];
   double dsum = 0.;
-  double dsum1 = 0.;
   double bl = 0.;
   double val_max = 0.;
   int samplemax = 0;
@@ -435,10 +434,8 @@ void EcalTestPulseAnalyzer::analyze(const edm::Event& e, const edm::EventSetup&
       }
       // Remove pedestal
       //====================
-      for (dsum = 0., dsum1 = 0., k = 0; k < _presample; k++) {
+      for (dsum = 0., k = 0; k < _presample; k++) {
         dsum += adc[k];
-        if (k < _presample - 1)
-          dsum1 += adc[k];
       }
 
       bl = dsum / ((double)_presample);
@@ -561,10 +558,8 @@ void EcalTestPulseAnalyzer::analyze(const edm::Event& e, const edm::EventSetup&
 
       // Remove pedestal
       //====================
-      for (dsum = 0., dsum1 = 0., k = 0; k < _presample; k++) {
+      for (dsum = 0., k = 0; k < _presample; k++) {
         dsum += adc[k];
-        if (k < _presample - 1)
-          dsum1 += adc[k];
       }
 
       bl = dsum / ((double)_presample);

diff --git a/CalibTracker/SiStripChannelGain/plugins/DeDxDiscriminatorLearner.cc b/CalibTracker/SiStripChannelGain/plugins/DeDxDiscriminatorLearner.cc
@@ -124,10 +124,9 @@ void DeDxDiscriminatorLearner::algoAnalyze(const edm::Event& iEvent, const edm::
   edm::Handle<reco::TrackCollection> trackCollectionHandle;
   iEvent.getByToken(m_tracksTag, trackCollectionHandle);
 
-  unsigned track_index = 0;
   for (TrajTrackAssociationCollection::const_iterator it = trajTrackAssociationHandle->begin();
        it != trajTrackAssociationHandle->end();
-       ++it, track_index++) {
+       ++it) {
     const Track& track = *it->val;
     const Trajectory& traj = *it->key;
 

diff --git a/Calibration/HcalCalibAlgos/plugins/AnalyzerMinbias.cc b/Calibration/HcalCalibAlgos/plugins/AnalyzerMinbias.cc
@@ -306,10 +306,16 @@ void AnalyzerMinbias::analyze(const edm::Event& iEvent, const edm::EventSetup& i
     const edm::Handle<L1GlobalTriggerObjectMapRecord> gtObjectMapRecord = iEvent.getHandle(tok_hltL1GtMap_);
     if (gtObjectMapRecord.isValid()) {
       const std::vector<L1GlobalTriggerObjectMap>& objMapVec = gtObjectMapRecord->gtObjectMap();
+#ifdef EDM_ML_DEBUG
       int ii(0);
+#endif
       bool ok(false), fill(true);
       for (std::vector<L1GlobalTriggerObjectMap>::const_iterator itMap = objMapVec.begin(); itMap != objMapVec.end();
+#ifdef EDM_ML_DEBUG
            ++itMap, ++ii) {
+#else
+           ++itMap) {
+#endif
         bool resultGt = (*itMap).algoGtlResult();
         if (resultGt == 1) {
           ok = true;

diff --git a/Calibration/IsolatedParticles/plugins/IsolatedGenParticles.cc b/Calibration/IsolatedParticles/plugins/IsolatedGenParticles.cc
@@ -653,9 +653,8 @@ void IsolatedGenParticles::analyze(const edm::Event &iEvent, const edm::EventSet
       }
     }
 
-    unsigned int indx;
     HepMC::GenEvent::particle_const_iterator p;
-    for (p = myGenEvent->particles_begin(), indx = 0; p != myGenEvent->particles_end(); ++p, ++indx) {
+    for (p = myGenEvent->particles_begin(); p != myGenEvent->particles_end(); ++p) {
       int pdgId = ((*p)->pdg_id());
       int ix = particleCode(pdgId);
       if (ix >= 0) {
@@ -770,9 +769,8 @@ void IsolatedGenParticles::analyze(const edm::Event &iEvent, const edm::EventSet
       }
     }  // loop over gen particles
 
-    unsigned int indx;
     reco::GenParticleCollection::const_iterator p;
-    for (p = genParticles->begin(), indx = 0; p != genParticles->end(); ++p, ++indx) {
+    for (p = genParticles->begin(); p != genParticles->end(); ++p) {
       int pdgId = (p->pdgId());
       int ix = particleCode(pdgId);
       if (ix >= 0) {

diff --git a/Calibration/IsolatedParticles/plugins/StudyCaloGen.cc b/Calibration/IsolatedParticles/plugins/StudyCaloGen.cc
@@ -407,9 +407,8 @@ void StudyCaloGen::analyze(const edm::Event &iEvent, const edm::EventSetup &iSet
       }
     }
 
-    unsigned int indx;
     HepMC::GenEvent::particle_const_iterator p;
-    for (p = myGenEvent->particles_begin(), indx = 0; p != myGenEvent->particles_end(); ++p, ++indx) {
+    for (p = myGenEvent->particles_begin(); p != myGenEvent->particles_end(); ++p) {
       int pdgId = ((*p)->pdg_id());
       int ix = particleCode(pdgId);
       if (ix >= 0) {
@@ -524,9 +523,8 @@ void StudyCaloGen::analyze(const edm::Event &iEvent, const edm::EventSetup &iSet
       }
     }  // loop over gen particles
 
-    unsigned int indx;
     reco::GenParticleCollection::const_iterator p;
-    for (p = genParticles->begin(), indx = 0; p != genParticles->end(); ++p, ++indx) {
+    for (p = genParticles->begin(); p != genParticles->end(); ++p) {
       int pdgId = (p->pdgId());
       int ix = particleCode(pdgId);
       if (ix >= 0) {

diff --git a/Calibration/IsolatedParticles/plugins/StudyCaloResponse.cc b/Calibration/IsolatedParticles/plugins/StudyCaloResponse.cc
@@ -1083,10 +1083,9 @@ int StudyCaloResponse::trackPID(const reco::Track* pTrack,
                                 const edm::Handle<reco::GenParticleCollection>& genParticles) {
   int id(0);
   if (genParticles.isValid()) {
-    unsigned int indx;
     reco::GenParticleCollection::const_iterator p;
     double mindR(999.9);
-    for (p = genParticles->begin(), indx = 0; p != genParticles->end(); ++p, ++indx) {
+    for (p = genParticles->begin(); p != genParticles->end(); ++p) {
       int pdgId = std::abs(p->pdgId());
       int idx = (pdgId == 11) ? 1 : ((pdgId == 211) ? 2 : ((pdgId == 321) ? 3 : ((pdgId == 2212) ? 4 : 0)));
       if (idx > 0) {

diff --git a/Configuration/AlCa/python/autoCond.py b/Configuration/AlCa/python/autoCond.py
@@ -31,12 +31,12 @@
     'run2_data_promptlike_hi'      :    '140X_dataRun2_PromptLike_HI_v1',
     # GlobalTag with fixed snapshot time for Run2 HLT RelVals: customizations to run with fixed L1 Menu
     'run2_hlt_relval'              :    '140X_dataRun2_HLT_relval_v1',
-    # GlobalTag for Run3 HLT: identical the online GT 160X_dataRun3_HLT_v1 but with snapshot at 2026-02-23 14:53:19 (UTC)
-    'run3_hlt'                     :    '160X_dataRun3_HLT_frozen260223_v1',
-    # GlobalTag for Run3 data relvals (express GT): same as 160X_dataRun3_Express_v1 but with snapshot at 2026-02-23 14:53:19 (UTC)
-    'run3_data_express'            :    '160X_dataRun3_Express_frozen260223_v1',
-    # GlobalTag for Run3 data relvals (prompt GT): same as 160X_dataRun3_Prompt_v1 but with snapshot at 2026-02-23 14:53:19 (UTC)
-    'run3_data_prompt'             :    '160X_dataRun3_Prompt_frozen260223_v1',
+    # GlobalTag for Run3 HLT: identical the online GT 161X_dataRun3_HLT_v1 but with snapshot at 2026-05-20 10:10:39 (UTC)
+    'run3_hlt'                     :    '161X_dataRun3_HLT_frozen260520_v1',
+    # GlobalTag for Run3 data relvals (express GT): same as 161X_dataRun3_Express_v1 but with snapshot at 2026-05-20 10:12:15 (UTC)
+    'run3_data_express'            :    '161X_dataRun3_Express_frozen260520_v1',
+    # GlobalTag for Run3 data relvals (prompt GT): same as 161X_dataRun3_Prompt_v1 but with snapshot at 2026-05-20 10:14:30 (UTC)
+    'run3_data_prompt'             :    '161X_dataRun3_Prompt_frozen260520_v1',
     # GlobalTag for Run3 offline data reprocessing - snapshot at 2026-03-30 15:14:30 (UTC)
     'run3_data'                    :    '150X_dataRun3_v8',
     # GlobalTag for Run3 offline data reprocessing with Prompt GT, currently for 2022FG - snapshot at 2024-05-31 08:53:25 (UTC)
@@ -98,7 +98,7 @@
     # GlobalTag for MC production (cosmics) with perfectly aligned and calibrated detector for Phase1 2024, Strip tracker in DECO mode
     'phase1_2024_cosmics_design'   :    '140X_mcRun3_2024cosmics_design_deco_v11',
     # GlobalTag for MC production with realistic conditions for Phase1 2024 detector for Heavy Ion
-    'phase1_2024_realistic_hi'     :    '141X_mcRun3_2024_realistic_HI_v14',
+    'phase1_2024_realistic_hi'     :    '141X_mcRun3_2024_realistic_HI_v17',
     # GlobalTag for MC production with realistic conditions for Phase1 2024 detector for ppRef5TeV
     'phase1_2024_realistic_ppRef5TeV' : '141X_mcRun3_2024_realistic_ppRef5TeV_v7',
     # GlobalTag for MC production with perfectly aligned and calibrated detector for Phase1 2025

diff --git a/DQM/SiStripCommissioningAnalysis/src/CalibrationAlgorithm.cc b/DQM/SiStripCommissioningAnalysis/src/CalibrationAlgorithm.cc
@@ -49,8 +49,7 @@ void CalibrationAlgorithm::extract(const std::vector<TH1*>& histos) {
 
   // Extract histograms
   std::vector<TH1*>::const_iterator ihis = histos.begin();
-  unsigned int cnt = 0;
-  for (; ihis != histos.end(); ihis++, cnt++) {
+  for (; ihis != histos.end(); ihis++) {
     // Check for NULL pointer
     if (!(*ihis)) {
       continue;

diff --git a/DQM/SiStripCommissioningAnalysis/src/CalibrationScanAlgorithm.cc b/DQM/SiStripCommissioningAnalysis/src/CalibrationScanAlgorithm.cc
@@ -51,8 +51,7 @@ void CalibrationScanAlgorithm::extract(const std::vector<TH1*>& histos) {
 
   // Extract histograms
   std::vector<TH1*>::const_iterator ihis = histos.begin();
-  unsigned int cnt = 0;
-  for (; ihis != histos.end(); ihis++, cnt++) {
+  for (; ihis != histos.end(); ihis++) {
     // Check for NULL pointer
     if (!(*ihis)) {
       continue;

diff --git a/DQM/SiStripMonitorHardware/src/SiStripFEDMonitor.cc b/DQM/SiStripMonitorHardware/src/SiStripFEDMonitor.cc
@@ -424,10 +424,8 @@ void SiStripFEDMonitorPlugin::getMajority(const std::vector<std::pair<unsigned i
   unsigned int lCounter = 0;
 
   //std::cout << " --- First element: addr = " << lMajAddr << " counter = " << lCounter << std::endl;
-  unsigned int iele = 0;
   //bool foundMaj = false;
-  for (; lIter != aFeMajVec.end(); ++lIter, ++iele) {
-    //std::cout << " ---- Ele " << iele << " " << (*lIter).first << " " << (*lIter).second << " ref " << lMajAddr << std::endl;
+  for (; lIter != aFeMajVec.end(); ++lIter) {
     if ((*lIter).second == lMajAddr) {
       ++lCounter;
       //std::cout << " ----- =ref: Counter = " << lCounter << std::endl;
@@ -444,7 +442,6 @@ void SiStripFEDMonitorPlugin::getMajority(const std::vector<std::pair<unsigned i
       lCounter = 0;
       lMajAddr = (*lIter).second;
       --lIter;
-      --iele;
     }
   }
   // AV Bug here? The check has to be done regardless foundMaj == false or true

diff --git a/DQMServices/Components/plugins/DQMStoreStats.cc b/DQMServices/Components/plugins/DQMStoreStats.cc
@@ -506,8 +506,7 @@ void DQMStoreStats::calcIgProfDump(Folder& root) {
   root.mainrows_cumulative(sql_statement);
   root.summary(sql_statement);
   VIterator<Folder*> subsystems = root.CreateIterator();
-  size_t ii = 0;
-  for (subsystems.First(); !subsystems.IsDone(); subsystems.Next(), ++ii) {
+  for (subsystems.First(); !subsystems.IsDone(); subsystems.Next()) {
     subsystems.CurrentItem()->mainrows(sql_statement);
     subsystems.CurrentItem()->parents(sql_statement);
     subsystems.CurrentItem()->children(sql_statement);

diff --git a/DataFormats/Common/interface/RefVector.h b/DataFormats/Common/interface/RefVector.h
@@ -180,8 +180,7 @@ namespace edm {
     pointers.reserve(this->size());
     helpers.reserve(this->size());
 
-    size_type key = 0;
-    for (const_iterator i = begin(), e = end(); i != e; ++i, ++key) {
+    for (const_iterator i = begin(), e = end(); i != e; ++i) {
       member_type const* address = i->isNull() ? nullptr : &**i;
       pointers.push_back(address);
       helpers.emplace_back(i->id(), i->key());

diff --git a/DataFormats/PatCandidates/interface/IsolatedTrack.h b/DataFormats/PatCandidates/interface/IsolatedTrack.h
@@ -114,6 +114,8 @@ namespace pat {
 
       int fromPV() const { return fromPV_; }
 
+      int trackQuality() const { return trackQuality_; }
+
       bool isHighPurityTrack() const {
         return (trackQuality_ & (1 << reco::TrackBase::highPurity)) >> reco::TrackBase::highPurity;
       }

diff --git a/Fireworks/Core/src/CmsShowCommon.cc b/Fireworks/Core/src/CmsShowCommon.cc
@@ -137,10 +137,9 @@ void CmsShowCommon::permuteColors() {
 void CmsShowCommon::randomizeColors() {
   //   printf("Doing random_shuffle on existing colors ...\n");
 
-  int vi = 0;
   for (FWEventItemsManager::const_iterator i = m_context->eventItemsManager()->begin();
        i != m_context->eventItemsManager()->end();
-       ++i, ++vi) {
+       ++i) {
     FWDisplayProperties prop = (*i)->defaultDisplayProperties();
 
     int col = rand() % 17;  // randomize in first row of palette

diff --git a/Fireworks/Core/src/FWModelChangeManager.cc b/Fireworks/Core/src/FWModelChangeManager.cc
@@ -85,9 +85,8 @@ void FWModelChangeManager::endChanges() {
   //makes sure that 'changeSignalsAreDone is called if changeSignalsAreComing_ is sent
   bool guard(false);
   if (0 == --m_depth) {
-    unsigned int index = 0;
     for (std::set<const FWEventItem*>::iterator itChanges = m_itemChanges.begin(); itChanges != m_itemChanges.end();
-         ++itChanges, ++index) {
+         ++itChanges) {
       if (!guard) {
         // std::shared_ptr<FWModelChangeManager> done(this, &sendChangeSignalsAreDone);
         guard = true;
@@ -109,7 +108,7 @@ void FWModelChangeManager::endChanges() {
     }
     m_itemChanges.clear();
 
-    for (size_t ci = 0, ce = m_changes.size(), si = 0; ci != ce; ++ci, ++si) {
+    for (size_t ci = 0, ce = m_changes.size(); ci != ce; ++ci) {
       FWModelIds& changes = m_changes[ci];
       if (not changes.empty()) {
         if (!guard) {

diff --git a/Fireworks/ParticleFlow/plugins/FWPFCandidateWithHitsProxyBuilder.cc b/Fireworks/ParticleFlow/plugins/FWPFCandidateWithHitsProxyBuilder.cc
@@ -75,10 +75,9 @@ void FWPFCandidateWithHitsProxyBuilder::build(const FWEventItem* iItem,
   if (candidates == nullptr)
     return;
 
-  Int_t idx = 0;
   initPFRecHitsCollections();
   for (reco::PFCandidateCollection::const_iterator it = candidates->begin(), itEnd = candidates->end(); it != itEnd;
-       ++it, ++idx) {
+       ++it) {
     TEveCompound* comp = createCompound();
     setupAddElement(comp, product);
     // printf("products size %d/%d \n", (int)iItem->size(), product->NumChildren());

diff --git a/Geometry/HGCalCommonData/test/HGCalCellUVTester.cc b/Geometry/HGCalCommonData/test/HGCalCellUVTester.cc
@@ -126,9 +126,8 @@ void HGCalCellUVTester::beginRun(edm::Run const &iRun, edm::EventSetup const &iS
   edm::LogVerbatim("HGCalGeom") << "\nHGCalCellUVTester:: nCells " << nCells << " and placement index between "
                                 << indexMin << " and " << indexMax << "\n\n";
   auto start_t = std::chrono::high_resolution_clock::now();
-  unsigned int kk(0);
   std::unordered_map<int32_t, HGCalParameters::waferInfo>::const_iterator itr = hgpar_->waferInfoMap_.begin();
-  for (; itr != hgpar_->waferInfoMap_.end(); ++itr, ++kk) {
+  for (; itr != hgpar_->waferInfoMap_.end(); ++itr) {
     //for (auto itr = hgpar_->waferInfoMap_.begin(); itr != hgpar_->waferInfoMap_.end(); ++itr){
     if ((itr->second).part != HGCalTypes::WaferFull) {
       int indx = itr->first;

diff --git a/Geometry/HGCalGeometry/test/HGCalGeometryCheck.cc b/Geometry/HGCalGeometry/test/HGCalGeometryCheck.cc
@@ -103,8 +103,7 @@ void HGCalGeometryCheck::beginRun(const edm::Run&, const edm::EventSetup& iSetup
     sprintf(name, "RZ_%s", nameDetectors_[ih].c_str());
     sprintf(title, "R vs Z for %s", nameDetectors_[ih].c_str());
     h_RZ_.emplace_back(fs->make<TH2D>(name, title, nbinZ_, zmin_, zmax_, nbinR_, rmin_, rmax_));
-    unsigned int k(0);
-    for (int lay = layerF; lay <= layerL; ++lay, ++k) {
+    for (int lay = layerF; lay <= layerL; ++lay) {
       sprintf(name, "Mod_%s_L%d", nameDetectors_[ih].c_str(), lay);
       sprintf(title, "Modules in layer %d in %s", lay, nameDetectors_[ih].c_str());
       h_Mod_.emplace_back(fs->make<TH1D>(name, title, 200, -50, 50));

diff --git a/Geometry/HcalTowerAlgo/test/HcalGeometryDump.cc b/Geometry/HcalTowerAlgo/test/HcalGeometryDump.cc
@@ -60,8 +60,7 @@ void HcalGeometryDump::analyze(const edm::Event& /*iEvent*/, const edm::EventSet
     }
     edm::LogVerbatim("HCalGeom") << detIds.size() << " valid Ids for subdetector " << subdet;
     std::sort(detIds.begin(), detIds.end());
-    int counter = 0;
-    for (std::vector<unsigned int>::const_iterator i = detIds.begin(); i != detIds.end(); ++i, ++counter) {
+    for (std::vector<unsigned int>::const_iterator i = detIds.begin(); i != detIds.end(); ++i) {
       HcalDetId hid = HcalDetId(*i);
       auto cell = caloGeom->getGeometry(*i);
       edm::LogVerbatim("HCalGeom") << hid << "\tCaloCellGeometry " << cell->getPosition() << "\tHcalGeometry "

diff --git a/HLTrigger/Muon/plugins/HLTL1MuonSelector.cc b/HLTrigger/Muon/plugins/HLTL1MuonSelector.cc
@@ -61,9 +61,8 @@ void HLTL1MuonSelector::produce(edm::StreamID, edm::Event& iEvent, const edm::Ev
   LogTrace(metname) << "Number of muons " << muColl->size() << endl;
 
   L1MuonParticleCollection::const_iterator it;
-  L1MuonParticleRef::key_type l1ParticleIndex = 0;
 
-  for (it = muColl->begin(); it != muColl->end(); ++it, ++l1ParticleIndex) {
+  for (it = muColl->begin(); it != muColl->end(); ++it) {
     const L1MuGMTExtendedCand muonCand = (*it).gmtMuonCand();
     unsigned int quality = 0;
     bool valid_charge = false;

diff --git a/HeterogeneousCore/CUDAServices/plugins/CUDAService.cc b/HeterogeneousCore/CUDAServices/plugins/CUDAService.cc
@@ -1,3 +1,4 @@
+#include <cstring>
 #include <iomanip>
 #include <iostream>
 #include <limits>
@@ -199,10 +200,18 @@ CUDAService::CUDAService(edm::ParameterSet const& config) : verbose_(config.getU
   computeCapabilities_.reserve(numberOfDevices_);
 
   // NVIDIA system driver version, e.g. 470.57.02
+  // The NVML interface is not available on gaming GPUs. Just report "unknown" in that case.
   char systemDriverVersion[NVML_SYSTEM_DRIVER_VERSION_BUFFER_SIZE];
-  nvmlCheck(nvmlInitWithFlags(NVML_INIT_FLAG_NO_GPUS | NVML_INIT_FLAG_NO_ATTACH));
-  nvmlCheck(nvmlSystemGetDriverVersion(systemDriverVersion, sizeof(systemDriverVersion)));
-  nvmlCheck(nvmlShutdown());
+  nvmlReturn_t result = nvmlInitWithFlags(NVML_INIT_FLAG_NO_GPUS | NVML_INIT_FLAG_NO_ATTACH);
+  if (NVML_SUCCESS != result) {
+    edm::LogWarning("CUDAService") << "NVML library not available, cannot query NVIDIA driver version:\n"
+                                   << nvmlErrorString(result) << "\nReporting NVIDIA driver version as \"unknown\".";
+    std::strncpy(systemDriverVersion, "unknown", sizeof(systemDriverVersion) - 1);
+    systemDriverVersion[sizeof(systemDriverVersion) - 1] = '\0';
+  } else {
+    nvmlCheck(nvmlSystemGetDriverVersion(systemDriverVersion, sizeof(systemDriverVersion)));
+    nvmlCheck(nvmlShutdown());
+  }
 
   // CUDA driver version, e.g. 11.4
   // the full version, like 11.4.1 or 11.4.100, is not reported