[ROOT639] TF1 changes required to build root639 by akritkbehera · Pull Request #49818 · cms-sw/cmssw

akritkbehera · 2026-01-14T12:06:56Z

PR description:

Changes needed as the constructor of TF1 was modified in ROOT639.
Remove CINT compatibility constructors from TF1, THF2, and TF3

cmsbuild · 2026-01-14T12:07:26Z

cms-bot internal usage

cmsbuild · 2026-01-14T12:09:15Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49818/47472

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49818/47472/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49818/47472/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

makortel · 2026-01-14T14:24:12Z

    const int npar = order_ + 1;
    auto cheb = std::make_unique<siPixelLACalibration::Chebyshev>(order_, theFitRange_.first, theFitRange_.second);
-    f1_ = std::make_unique<TF1>("f1", cheb.release(), theFitRange_.first, theFitRange_.second, npar, "Chebyshev");
+    f1_ = std::make_unique<TF1>("f1", cheb.release(), theFitRange_.first, theFitRange_.second, npar);


It could be good to add the EAddToList::kNo (or "NL" if need to pass it as a string) to avoid adding the functions to the global list (that is not thread safe).

cmsbuild · 2026-01-15T13:45:16Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49818/47503

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49818/47503/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49818/47503/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2026-01-15T14:13:46Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49818/47504

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49818/47504/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49818/47504/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2026-01-15T14:17:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49818/47505

cmsbuild · 2026-01-15T14:18:22Z

A new Pull Request was created by @akritkbehera for master.

It involves the following packages:

CalibTracker/SiPixelLorentzAngle (alca)
SimG4CMS/Calo (simulation)

@Alejandro1400, @JanChyczynski, @arunhep, @atpathak, @civanch, @cmsbuild, @kpedro88, @mdhildreth, @perrotta can you please review it and eventually sign? Thanks.
@ReyerBand, @argiro, @bsunanda, @dkotlins, @fabiocos, @felicepantaleo, @ferencek, @martinamalberti, @mmusich, @mroguljic, @rchatter, @rovere, @rsreds, @slomeo, @thomreis, @tocheng, @tsusa, @wang0jin, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2026-01-16T09:03:29Z

please test

smuzaffar · 2026-01-16T09:04:18Z

this change works for new ROOT master

cmsbuild · 2026-01-16T10:49:59Z

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-744b0f/50670/summary.html
COMMIT: 2174999
CMSSW: CMSSW_16_1_X_2026-01-15-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49818/50670/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 52
DQMHistoTests: Total histograms compared: 4025536
DQMHistoTests: Total failures: 44
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4025472
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
Checked 222 log files, 193 edm output root files, 52 DQM output files
TriggerResults: no differences found

perrotta · 2026-01-16T11:01:44Z

+alca

smuzaffar · 2026-01-16T11:08:06Z

@cms-sw/simulation-l2 can you please review this change ? This is needed due to changes in ROOT master

civanch · 2026-01-16T11:08:24Z

+1

cmsbuild · 2026-01-16T11:08:32Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

smuzaffar · 2026-01-16T17:06:44Z

@cms-sw/orp-l2 , can we get this in next IB? This is needed for ROOT6_X update cms-sw/cmsdist#10274

mandrenguyen · 2026-01-17T09:07:59Z

+1

TF1 changes required to build root639

72aa207

cmsbuild added this to the CMSSW_16_1_X milestone Jan 14, 2026

cmsbuild added simulation-pending alca-pending pending-signatures tests-pending orp-pending code-checks-pending trk labels Jan 14, 2026

akritkbehera mentioned this pull request Jan 14, 2026

[ROOT639] Updated root to tip of branch master cms-sw/cmsdist#10274

Merged

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jan 14, 2026

makortel reviewed Jan 14, 2026

View reviewed changes

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jan 15, 2026

akritkbehera marked this pull request as ready for review January 15, 2026 13:43

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jan 15, 2026

akritkbehera force-pushed the root639_fix branch from b737d25 to a7300b5 Compare January 15, 2026 14:12

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jan 15, 2026

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jan 15, 2026

Updated TF1 constructor calls

2174999

akritkbehera force-pushed the root639_fix branch from a7300b5 to 2174999 Compare January 15, 2026 14:16

cmsbuild removed the code-checks-rejected label Jan 15, 2026

cmsbuild added the code-checks-pending label Jan 15, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 15, 2026

cmsbuild added tests-started and removed tests-pending labels Jan 16, 2026

cmsbuild added tests-approved and removed tests-started labels Jan 16, 2026

cmsbuild added alca-approved and removed alca-pending labels Jan 16, 2026

cmsbuild added simulation-approved fully-signed and removed simulation-pending pending-signatures labels Jan 16, 2026

cmsbuild added orp-approved and removed orp-pending labels Jan 17, 2026

cmsbuild merged commit 52be86b into cms-sw:master Jan 17, 2026
10 checks passed

Conversation

akritkbehera commented Jan 14, 2026

PR description:

Uh oh!

cmsbuild commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jan 14, 2026

Uh oh!

makortel Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Jan 15, 2026

Uh oh!

cmsbuild commented Jan 15, 2026

Uh oh!

cmsbuild commented Jan 15, 2026

Uh oh!

cmsbuild commented Jan 15, 2026

Uh oh!

smuzaffar commented Jan 16, 2026

Uh oh!

smuzaffar commented Jan 16, 2026

Uh oh!

cmsbuild commented Jan 16, 2026

Comparison Summary

Uh oh!

perrotta commented Jan 16, 2026

Uh oh!

smuzaffar commented Jan 16, 2026

Uh oh!

civanch commented Jan 16, 2026

Uh oh!

cmsbuild commented Jan 16, 2026

Uh oh!

smuzaffar commented Jan 16, 2026

Uh oh!

mandrenguyen commented Jan 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

cmsbuild commented Jan 14, 2026 •

edited

Loading