Skip to content

Add RISC-V CI test coverage#229

Open
liuq19 wants to merge 5 commits into
cloudwego:mainfrom
liuq19:codex/riscv-ci-tests
Open

Add RISC-V CI test coverage#229
liuq19 wants to merge 5 commits into
cloudwego:mainfrom
liuq19:codex/riscv-ci-tests

Conversation

@liuq19

@liuq19 liuq19 commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add a stable CI job for riscv64gc-unknown-linux-gnu.
  • Use taiki-e/setup-cross-toolchain-action with the qemu-user runner so cargo test --verbose executes under RISC-V emulation.

Validation

  • rustup +stable target add riscv64gc-unknown-linux-gnu
  • cargo +stable check --target riscv64gc-unknown-linux-gnu --all-targets
  • python3 -c 'import yaml; yaml.safe_load(open(".github/workflows/ci.yml")); print("ok")'
  • git diff --check

Note: the local cross-compile check emitted host CPU feature warnings from this machine's compiler flags when targeting RISC-V, but completed successfully.

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.16%. Comparing base (03545a9) to head (1aa7261).

Files with missing lines Patch % Lines
src/lazyvalue/value.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   71.16%   71.16%           
=======================================
  Files          42       42           
  Lines        9762     9762           
=======================================
  Hits         6947     6947           
  Misses       2815     2815           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liuq19 liuq19 marked this pull request as ready for review June 26, 2026 07:49
Copilot AI review requested due to automatic review settings June 26, 2026 07:49
@liuq19 liuq19 changed the title [codex] Add RISC-V CI test coverage Add RISC-V CI test coverage Jun 26, 2026
shenyj3
shenyj3 previously approved these changes Jun 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds CI coverage intended to run the test suite on RISC-V (riscv64gc-unknown-linux-gnu) under QEMU emulation, alongside a couple of small Rust cleanups.

Changes:

  • Add a new GitHub Actions job for stable RISC-V testing using taiki-e/setup-cross-toolchain-action with qemu-user.
  • Minor parser token-matching refactors to use byte-string literals for token arrays.
  • Small cleanup in LazyValue’s Debug formatting.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/parser.rs Refactors several token-array literals to byte-string equivalents for scanning/branching logic.
src/lazyvalue/value.rs Simplifies a format_args! call in Debug output.
.github/workflows/ci.yml Adds a new stable CI job intended to run tests under RISC-V emulation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants