Add RISC-V CI test coverage#229
Open
liuq19 wants to merge 5 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
=======================================
Coverage 71.16% 71.16%
=======================================
Files 42 42
Lines 9762 9762
=======================================
Hits 6947 6947
Misses 2815 2815 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
shenyj3
previously approved these changes
Jun 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CI coverage intended to run the test suite on RISC-V (riscv64gc-unknown-linux-gnu) under QEMU emulation, alongside a couple of small Rust cleanups.
Changes:
- Add a new GitHub Actions job for stable RISC-V testing using
taiki-e/setup-cross-toolchain-actionwithqemu-user. - Minor parser token-matching refactors to use byte-string literals for token arrays.
- Small cleanup in
LazyValue’sDebugformatting.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/parser.rs |
Refactors several token-array literals to byte-string equivalents for scanning/branching logic. |
src/lazyvalue/value.rs |
Simplifies a format_args! call in Debug output. |
.github/workflows/ci.yml |
Adds a new stable CI job intended to run tests under RISC-V emulation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
riscv64gc-unknown-linux-gnu.taiki-e/setup-cross-toolchain-actionwith theqemu-userrunner socargo test --verboseexecutes under RISC-V emulation.Validation
rustup +stable target add riscv64gc-unknown-linux-gnucargo +stable check --target riscv64gc-unknown-linux-gnu --all-targetspython3 -c 'import yaml; yaml.safe_load(open(".github/workflows/ci.yml")); print("ok")'git diff --checkNote: the local cross-compile check emitted host CPU feature warnings from this machine's compiler flags when targeting RISC-V, but completed successfully.