[codex] fix deepseek thinking config for streams#808
Open
k8scat wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a DeepSeek streaming bug where ThinkingConfig was applied to non-stream Generate requests but inadvertently dropped from Stream requests.
Changes:
- Forward
Thinkingfrom the non-stream request intodeepseek.StreamChatCompletionRequestingenerateStreamRequest. - Add a regression test ensuring stream requests carry the
ThinkingConfig.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
components/model/deepseek/deepseek.go |
Copies Thinking into the stream request so DeepSeek “thinking mode” is preserved for streaming. |
components/model/deepseek/deepseek_test.go |
Adds a regression test that captures the stream request and asserts Thinking.Type is forwarded. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
@JonXSnow 大佬帮忙review下 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
generateStreamRequestbuilds a stream request from the non-stream request but did not copy theThinkingfield, soChatModelConfig.ThinkingConfigwas applied to Generate but dropped for Stream.Validation
git diff --check main...HEADGOTOOLCHAIN=go1.24.1 go test ./... -count=1 -gcflags="all=-N -l"incomponents/model/deepseekFixes #807