fix(ark): add Dimensions field to EmbeddingConfig#790
Open
wucm667 wants to merge 4 commits into
Open
Conversation
|
|
wucm667
force-pushed
the
fix/ark-embedding-dimensions
branch
from
298fc46 to
c924c7e
Compare
Add optional Dimensions field to EmbeddingConfig struct, allowing users to specify embedding vector dimensions when creating embeddings. This fixes the issue where the Indexer specifies Dimensions but the EmbeddingConfig lacks this parameter, causing embedding creation to fail. Closes cloudwego#647
wucm667
force-pushed
the
fix/ark-embedding-dimensions
branch
from
c924c7e to
ad46313
Compare
Author
|
Hi! The All actual tests pass successfully: Could someone with repo admin access check the workflow permissions? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional
Dimensionsfield toEmbeddingConfigstruct, allowing users to specify embedding vector dimensions when creating embeddings.This fixes the issue where the Indexer specifies Dimensions but the EmbeddingConfig lacks this parameter, causing embedding creation to fail.
Closes #647