Migrate on-push PR jobs from Gitlab over to Github#3275
Closed
jaschutte wants to merge 3 commits into
Closed
Conversation
Simply compiles clash for cabal & stack, Nix runs tests by default so there is no need to duplicate those.
Runs clash-testsuite using Nix, does all compiler & HDLs in parallel to make optimal use of the runners
Contributor
Author
|
Another thing to note; this does not remove the old Gitlab pipeline yet. I think its best to do that all at once once all Gitlab jobs have been migrated. |
Member
|
Do you ensure memory limits on the host side? If not, you could do the poor man's thing we do over at |
Contributor
Author
|
We have configured the backend hosting the runners to limit the CPUs per job, memory I am not quite sure but it shouldn't be a difficult thing to add (iirc it's literally just an option inside of docker-compose). |
Contributor
Author
|
Closing as this is a PR from a fork and not from a main branch, therefore the new tests ironically enough don't run. See #3289 for the new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have self-hosted Github runners, however we still mirror the repository to Gitlab to run jobs on PRs. This migrates over the jobs that the Gitlab runners do over to Github. In specific; only the jobs performed on push are copied over. This includes the following set of jobs:
Nix automatically caches whatever it builds to our local cache, pushes to the master branch also get cached in Cachix.
Cabal caches only the clash dependencies (the key is the hash of the cabal.project file, I think this should be correct as its the only thing that changes the dependencies(?). If not, let me know and I will change it to something else. Maybe the
.cabalfiles should be part of the key too?) It uses the local minio cache.Stack does not utilize caching.
TODO:
.cabalto the key to the Cabal cache