Sigma Delta ADC#2617
Open
FloriaanB wants to merge 17 commits into
Open
Conversation
…piler into SigmaDeltaADC
Member
lmbollen
requested changes
Dec 15, 2023
Member
lmbollen
left a comment
lmbollen
left a comment
There was a problem hiding this comment.
In general I really like the clarity of the code + the documentation.
However, I do think we could do with less one time use functions, we could move some functionality to the respective components. I'll discuss more irl
| ) | ||
| => SNat n0 | ||
| -- ^ ADC width | ||
| -> SNat (n0 + n1) |
Member
There was a problem hiding this comment.
How do I determine this number?
| -- ^ Accumulator width | ||
| -- Has to be larger or equal to the ADC width, | ||
| -- the OSR is equal to 2^(AccumulatorWidth - ADCwidth) | ||
| -> SNat n2 |
Member
There was a problem hiding this comment.
How do I determine this number?
Comment on lines
+249
to
+252
| -- 1. feedback to the RC network: | ||
| -- The R and C of the low pass network need to be chosen such that: | ||
| -- RC inbetween 200 and 1000 x clk, where clk is the frequency of | ||
| -- output |
Member
There was a problem hiding this comment.
I think this too, should be at module level or function level.
Member
There was a problem hiding this comment.
Is there an optimal value? if so, how do we choose it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a Sigma Delta ADC to Clash Cores
Still TODO: