Skip to content

Report changes in simpleCSE#1848

Merged
alex-mckenna merged 1 commit into
masterfrom
issue-1846
Jun 11, 2021
Merged

Report changes in simpleCSE#1848
alex-mckenna merged 1 commit into
masterfrom
issue-1846

Conversation

@alex-mckenna

@alex-mckenna alex-mckenna commented Jun 9, 2021

Copy link
Copy Markdown
Contributor

The simpleCSE transformation previously never reported when it had
changed the resulting AST. With the fix from f68204f this meant
that CSE would often cause failures when using DebugApplied or
higher.

Fixes #1846

Still TODO:

  • Write a changelog entry (see changelog/README.md)
  • Check copyright notices are up to date in edited files
  • Make sure the testsuite can detect such errors move to Improved -fclash-debug-* flags #1847

The simpleCSE transformation previously never reported when it had
changed the resulting AST. With the fix from f68204f this meant
that CSE would often cause failures when using DebugApplied or
higher.
@alex-mckenna alex-mckenna requested a review from leonschoorl June 9, 2021 10:48
@leonschoorl

Copy link
Copy Markdown
Member

The testsuite should have caught this

@alex-mckenna

Copy link
Copy Markdown
Contributor Author

The testsuite should have caught this

Discussed offline, the testsuite runs with DebugSilent which is too low to catch this failure (which needs DebugApplied or higher). The best course of action is to change when checks like this are performed in #1800 which touches that logic anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected changes in CSE

2 participants