Report changes in simpleCSE#1848
Merged
Merged
Conversation
The simpleCSE transformation previously never reported when it had changed the resulting AST. With the fix from f68204f this meant that CSE would often cause failures when using DebugApplied or higher.
leonschoorl
approved these changes
Jun 11, 2021
Member
|
The testsuite should have caught this |
Contributor
Author
Discussed offline, the testsuite runs with |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The simpleCSE transformation previously never reported when it had
changed the resulting AST. With the fix from f68204f this meant
that CSE would often cause failures when using DebugApplied or
higher.
Fixes #1846
Still TODO:
Make sure the testsuite can detect such errorsmove to Improved-fclash-debug-*flags #1847