widgets: change dropdown style to readonly#946
Open
simonsbench wants to merge 1 commit into
Open
Conversation
The Dropdown widget's wx.ComboBox creation used the wx.CB_DROPDOWN style flag, which allows selection but also makes the selection editable. wx.CB_READONLY allows selection but without editing, so the selection will always be in the enumerated choice. See: https://docs.wxpython.org/wx.ComboBox.html#wx-combobox Fixes: chriskiehl#925
Author
See dropdown options as selectable but editable before the style fix, and then only selectable after the fix. |
Author
|
(I found this discussion about 1.0.9 (#773), and it sounds like it isn't a good release candidate. I'll issue bug fixes that aren't feature improvements against 1.0.8-release, as this makes releasing them easy.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dropdown widget's wx.ComboBox creation used the wx.CB_DROPDOWN style flag,
which allows selection but also makes the selection editable. wx.CB_READONLY
allows selection but without editing, so the selection will always be in the
enumerated choice. See: https://docs.wxpython.org/wx.ComboBox.html#wx-combobox
Fixes: #925