Open the chart on the ranking that is being read - #41
Merged
Conversation
The link stood in the section header, above the tabs, and always opened the most starred repositories - whichever ranking someone was reading. It now sits in the panel itself, at the right end of the caption, and every panel carries its own: the chart it opens draws the repositories of that ranking, in that order, as many as the chart has colours for. Nothing to switch, since only the visible panel can be clicked - the link is rendered per ranking rather than rewritten when a tab is picked. A ranking that came out empty has nothing to draw and gets none. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Open the chart" button of the rankings section always opened the most starred repositories, no matter which ranking was on screen.
It moves out of the section header and into the tab panel, at the right end of the caption. Every panel renders its own link, drawn with the top repositories of that ranking, in that order, up to
CHART_LIMIT- so the button opens what is being read, and nothing has to be rewritten when a tab is picked, since only the visible panel can be clicked. A ranking that came out empty (nothing got more complex in the last 12 months) has nothing to draw and gets no link..ranking__introis the caption and the link on one line - it wraps and the link drops under the caption on a phone.Checked:
lint:twig,phpunit(126 tests), prettier,yarn build, plus screenshots of the start page at 1440 and 420 wide and of a panel with a two-line caption.Not touched:
CLAUDE.md. The paragraph describing the start page is being rewritten in the working copy right now, so a doc edit here would only collide - the rule is written down in the template at the place it applies.🤖 Generated with Claude Code