Skip to content

refactor: switch from micromatch to picomatch - #1284

Open
hyperz111 wants to merge 3 commits into
chimurai:masterfrom
hyperz111:micromatch-to-picomatch
Open

refactor: switch from micromatch to picomatch#1284
hyperz111 wants to merge 3 commits into
chimurai:masterfrom
hyperz111:micromatch-to-picomatch

Conversation

@hyperz111

@hyperz111 hyperz111 commented Aug 8, 2026

Copy link
Copy Markdown

Description

This change replace the micromatch dependency with picomatch.

Motivation and Context

picomatch is a core engine behind micromatch.
But micromatch brings 5 dependencies in its tree and only picomatch that really used in our project.
So, I take a initiative to use the core engine directly.

How has this been tested?

I have do a test when changing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Summary by CodeRabbit

  • Bug Fixes
    • Improved glob pattern matching, including support for combinations of positive and negated patterns.
    • Enhanced matching performance through cached pattern processing.
    • Replaced the underlying matching library without changing the public API.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3283e9c1-19ff-424c-a82b-aad55f684471

📥 Commits

Reviewing files that changed from the base of the PR and between 1b90ce8 and e4a33a9.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • package.json
  • src/path-filter.ts

📝 Walkthrough

Walkthrough

The path filter replaces micromatch with picomatch. It caches compiled matchers for single and multiple glob patterns and explicitly evaluates positive and negated patterns.

Changes

Path filtering

Layer / File(s) Summary
Matcher dependency and compilation
package.json, src/path-filter.ts
The project replaces micromatch packages with picomatch. Single-pattern matching uses cached compiled matchers against URL pathnames.
Multi-pattern evaluation
src/path-filter.ts
Multi-pattern matching caches compiled patterns, tracks positive and negated matches, and computes the final inclusion result.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: chimurai

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change from micromatch to picomatch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant