Skip to content

fix(getDataWriter): close FileOutputStream in getD #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tejasae-afk wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(getDataWriter): close FileOutputStream in getD #292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/main/java/com/tagtraum/perf/gcviewer/exp/impl/DataWriterFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,16 @@ public static DataWriter getDataWriter(File file, DataWriterType type) throws IO
* @throws IOException unknown DataWriter or problem creating file
*/
public static DataWriter getDataWriter(File file, DataWriterType type, Map<String, Object> configuration) throws IOException {
FileOutputStream outputStream = new FileOutputStream(file);
switch (type) {
case PLAIN : return new PlainDataWriter(outputStream);
case CSV : return new CSVDataWriter(outputStream);
case CSV_TS : return new CSVTSDataWriter(outputStream);
case SIMPLE : return new SimpleGcWriter(outputStream);
case SUMMARY : return new SummaryDataWriter(outputStream, configuration);
case PNG : return new PNGDataWriter(outputStream, configuration);
default : throw new IOException(LocalisationHelper.getString("datawriterfactory_instantiation_failed") + " " + file);
try (FileOutputStream outputStream = new FileOutputStream(file)) {
switch (type) {
case PLAIN : return new PlainDataWriter(outputStream);
case CSV : return new CSVDataWriter(outputStream);
case CSV_TS : return new CSVTSDataWriter(outputStream);
case SIMPLE : return new SimpleGcWriter(outputStream);
case SUMMARY : return new SummaryDataWriter(outputStream, configuration);
case PNG : return new PNGDataWriter(outputStream, configuration);
default : throw new IOException(LocalisationHelper.getString("datawriterfactory_instantiation_failed") + " " + file);
}
}
}

Expand Down