movielens: revert to using standard "edit name" dialog#599
Merged
Conversation
The movielens edit modal dialog had a "Custom Name" field, but it has proven to be problematic and conflicts with the normal "pen edit" icon next to the catalog name. Even after the recent fixes which sync the latest name into the modal dialog every time it's re-opened, there's still the reverse bug: Every time the normal "pen edit" is clicked, the normal naming dialog doesn't know about the name changes that were performed via the modal dialog. Instead of trying to make an invasive two-way sync between the dialogs, it's cleaner to just rely on the normal "pen edit" naming popup that all other catalogs use. It also saves space in the MovieLens dialog.
Contributor
PR Guard
Maintainers may still close PRs that do not match project direction or review capacity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The movielens edit modal dialog had a "Custom Name" field, but it has proven to be problematic and conflicts with the normal "pen edit" icon next to the catalog name.
Even after the recent fixes which sync the latest name into the modal dialog every time it's re-opened, there's still the reverse bug: Every time the normal "pen edit" is clicked, the normal naming dialog doesn't know about the name changes that were performed via the modal dialog.
Instead of trying to make an invasive two-way sync between the dialogs, it's cleaner to just rely on the normal "pen edit" naming popup that all other catalogs use. It also saves space in the MovieLens dialog.
Linked issue
None.
Type of change
Why this approach
See summary.
Testing
Describe exactly how you tested this change.
Documentation
Author checklist
CONTRIBUTING.md.AI usage disclosure