Skip to content

movielens: always exclude unreleased movies from explore-catalogs#595

Merged
0xConstant1 merged 1 commit into
cedya77:devfrom
Arcitec:ml-remove-unreleased
Jul 23, 2026
Merged

movielens: always exclude unreleased movies from explore-catalogs#595
0xConstant1 merged 1 commit into
cedya77:devfrom
Arcitec:ml-remove-unreleased

Conversation

@Arcitec

@Arcitec Arcitec commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

Apply maxFutureDays=0 globally to all "explore" catalogs, to prevent unreleased movies from ever appearing in search and recommendation results.

They were still appearing in several previously unhandled situations, such as "minYear=2026" (which then easily surfaced plenty of future "2029" releases). Instead of trying to catch every scenario (maxDaysAgo, sortBy=releaseDate, minYear=2026, etc), let's just universally exclude them from exploration catalogs.

Unreleased titles cannot be streamed or even be watched in cinemas yet, and they lack meaningful ratings/tags, making them catalog noise.

Linked issue

None.

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Tests only
  • Documentation only
  • CI / tooling

Why this approach

See summary.

Testing

Describe exactly how you tested this change.

  • I ran existing tests relevant to this change.
  • I added or updated tests where needed.
  • No tests were needed, and I explained why.

Documentation

  • I updated documentation or comments where needed.
  • No documentation updates were needed.

Author checklist

  • This PR is focused on one concern.
  • This PR is reasonably small and reviewable.
  • I read and followed CONTRIBUTING.md.
  • I can explain every code change in this PR.
  • I will respond to review feedback myself.

AI usage disclosure

  • No AI tools were used.
  • AI tools were used for part of this PR, and I personally reviewed and verified all changes.

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

PR Guard

  • Non-trivial PRs must link an issue in the PR body.

Maintainers may still close PRs that do not match project direction or review capacity.

@Arcitec

Arcitec commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

An easy way to test this:

  • Create a catalog with these parameters:
  • Sort By: Prediction (personalized)
  • Min Year: 2026
  • Then go into your streaming app's discover feature, and set Genre to Animation.
  • Without this pull request: You'll see Coco 2 (2029) and other noise. With this pull request: You only see movies available in cinemas or at home. Thus improving the recommendation catalog quality.
  • The maxFutureDays parameter is still manually settable, if a future update ever wants to expose it to the user. However, it's unlikely that unreleased movies would ever belong in these recommendation catalogs, since nobody has seen/rated/tagged them yet, so they're just noise.

@0xConstant1

Copy link
Copy Markdown
Collaborator

Can you fix the linting error real quick?

@Arcitec

Arcitec commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

@0xConstant1

Can you fix the linting error real quick?

It seems like it's just complaining that I removed the #linked issue section of the PR template. I re-added it already but it didn't re-evaluate the PR. So no I don't think I can do anything about it from here. :/

@0xConstant1

Copy link
Copy Markdown
Collaborator

@0xConstant1

Can you fix the linting error real quick?

It seems like it's just complaining that I removed the #linked issue section of the PR template. I re-added it already but it didn't re-evaluate the PR. So no I don't think I can do anything about it from here. :/

I was talking about the missing semi-colon in your code.

Apply maxFutureDays=0 globally to all "explore" catalogs, to prevent unreleased movies from ever appearing in search and recommendation results.

They were still appearing in several previously unhandled situations, such as "minYear=2026" (which then easily surfaced plenty of future "2029" releases). Instead of trying to catch every scenario (maxDaysAgo, sortBy=releaseDate, minYear=2026, etc), let's just universally exclude them from exploration catalogs.

Unreleased titles cannot be streamed or even be watched in cinemas yet, and they lack meaningful ratings/tags, making them catalog noise.
@Arcitec
Arcitec force-pushed the ml-remove-unreleased branch from 615fa61 to f51f387 Compare July 23, 2026 18:33
@Arcitec

Arcitec commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

@0xConstant1 Oh on the isExplore line! Fixed!

@0xConstant1

Copy link
Copy Markdown
Collaborator

ty for your contribution 👍

@0xConstant1
0xConstant1 merged commit 7957d82 into cedya77:dev Jul 23, 2026
0 of 2 checks passed
@Arcitec
Arcitec deleted the ml-remove-unreleased branch July 23, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants