Skip to content

Update code to work with recent abseil changes#1919

Open
kkufieta wants to merge 1 commit into
cartographer-project:masterfrom
kkufieta:kk/fix-absl
Open

Update code to work with recent abseil changes#1919
kkufieta wants to merge 1 commit into
cartographer-project:masterfrom
kkufieta:kk/fix-absl

Conversation

@kkufieta

@kkufieta kkufieta commented Feb 28, 2023

Copy link
Copy Markdown

This patch fixes compilation issues caused by the most recent changes to abseil-cpp: https://github.com/abseil/abseil-cpp/releases:

The legacy spellings of the thread annotation macros/functions (e.g. GUARDED_BY()) have been removed by default in favor of the ABSL_ prefixed versions (e.g. ABSL_GUARDED_BY()) due to clashes with other libraries. The compatibility macro ABSL_LEGACY_THREAD_ANNOTATIONS can be defined on the compile command-line to temporarily restore these spellings, but this compatibility macro will be removed in the future.

Signed-off-by: Katharina Xenia Kufieta <katharina.kufieta@gmail.com>
@kkufieta

Copy link
Copy Markdown
Author

Gentle ping - I would love to get these changes merged so we can stop using the ABSL_LEGACY_THREAD_ANNOTATIONS compatibility macro before it is going to be removed in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant