Export all DataPoints to console#430
Open
schiwekM wants to merge 1 commit into
Open
Conversation
Contributor
SummaryThe following content is AI-generated and provides a summary of the pull request: Fix Console Exporter to Export All DataPoints🐛 Bug Fix: The console metric exporter was only writing the last data point to the console when a metric had multiple data points. This PR fixes the issue by collecting all data points and logging them correctly. Changes
PR Bot InformationVersion:
|
Contributor
There was a problem hiding this comment.
The PR correctly addresses the bug where only the last data point was written. Two issues were raised: (1) the other branch stores full datapoint objects (dp) instead of their values (dp.value), which is inconsistent with pool/queue handling, and (2) the unwrapping condition v.length === 1 should be guarded with Array.isArray(v) for robustness.
PR Bot Information
Version: 1.20.51
- LLM:
anthropic--claude-4.6-sonnet - File Content Strategy: Full file content
- Event Trigger:
pull_request.opened - Correlation ID:
6b1870c7-a441-4462-860a-1eb46e4e2a77
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a metric has two data points the console exporter currently only writes the last one to console. The PR fixes that.