fix: calculated elements in drafts#1635
Open
johannes-vogel wants to merge 1 commit into
Open
Conversation
johannes-vogel
requested review from
BobdenOs,
danjoa,
patricebender,
sjvans and
stewsk
as code owners
danjoa
approved these changes
Jun 3, 2026
|
|
||
| let result = is_regexp(token?.val) ? token : copy(token) // REVISIT: too expensive! // | ||
| let result = is_regexp(token?.val) ? token : copy(token) // REVISIT: too expensive! | ||
| // REVISIT: required because we copy the token above and lose the not enumerable "param: false" |
Contributor
There was a problem hiding this comment.
We should avoid copying the token at all, imho. → see my old, ignored REVISIT comment above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.