Single attachment#376
Open
eric-pSAP wants to merge 72 commits into
Open
Conversation
Co-authored-by: hyperspace-insights[bot] <209611008+hyperspace-insights[bot]@users.noreply.github.com>
![hyperspace-insights[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Summary
This PR introduces several substantive issues: the SingleMediaData type has an incorrectly defined association that won't work with types (only entities support associations), and the attachDeletionData method contains unsafe array operations that could fail when attachments lack ID fields. Additionally, the test schema redundantly redefines the ID key. These should be addressed before merging.
PR Bot Information
Version: 1.17.61 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback
- Correlation ID:
e0eda0c0-0ccb-11f1-993b-86fda88b4de0 - Event Trigger:
pull_request.opened - LLM:
anthropic--claude-4.5-sonnet
Co-authored-by: hyperspace-insights[bot] <209611008+hyperspace-insights[bot]@users.noreply.github.com>
eric-pSAP
force-pushed
the
singleAttachment
branch
from
6f8a0e7 to
06b68c0
Compare
# Conflicts: # lib/csn-runtime-extension.js # lib/generic-handlers.js # package.json # srv/attachments/basic.js # tests/incidents-app/db/attachments.cds # tests/incidents-app/db/schema.cds # tests/incidents-app/srv/services.cds # tests/integration/attachments.test.js
KoblerS
reviewed
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowing attachments to be assignable as a type. Allows for only 1 single attachment instead of a composition of many.