fix: sort embedded file name tree entries - #147
Open
Guflly wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks for the PR. You're right about the problem. But I fixed with a commit that also handles the problem with js scripts. Can you test with version 2.8.2 please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Keeps
EmbeddedFilesname-tree keys sorted by their encoded PDF bytes.Why?
Acrobat rejects some attachments when names such as
1.jpg,2.jpg, and10.jpgare stored out of order.How?
The attachment key and reference are inserted at the correct byte-sorted position in the name tree.
Testing?
Ran the full unit suite (804 passed, 1 skipped), typecheck, ESLint, Prettier, and the full build. A targeted Node check and real Chrome and Firefox browser checks verified byte-sorted attachment names in both a newly created PDF and an existing fixture. Chrome's PDF viewer rendered both generated documents. Deno and the complete desktop viewer matrix were not run.
New Dependencies?
No.
Screenshots
N/A.
Suggested Reading?
No.
Anything Else?
Closes #89.
Checklist