feat(admin): add Prometheus-backed /admin/metrics SSE endpoint#662
Draft
Ferryx349 wants to merge 7 commits into
Draft
feat(admin): add Prometheus-backed /admin/metrics SSE endpoint#662Ferryx349 wants to merge 7 commits into
Ferryx349 wants to merge 7 commits into
Conversation
Signed-off-by: ABHAY PANDEY <pandeyabhay967@gmail.com>
- Move admin enabled/auth checks into request-handlers middleware - Reuse admin auth provider instance per process - Deduplicate admin rate-limit middleware via scope factory - Return JSON errors from admin controller wrapper - Drop duplicated sessionTtlSeconds default from settings yaml Signed-off-by: ABHAY PANDEY <pandeyabhay967@gmail.com>
…L metrics Signed-off-by: ABHAY PANDEY <pandeyabhay967@gmail.com>
Stack admin auth routes required for authenticated /admin/metrics SSE. Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: ABHAY PANDEY <pandeyabhay967@gmail.com>
🦋 Changeset detectedLatest commit: b58e212 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| router.use(rateLimiterMiddleware) | ||
| // codeql[js/missing-rate-limiting] - feature gate only, not authentication | ||
| router.use(adminEnabledMiddleware) | ||
| router.post('/login', adminLoginRateLimitMiddleware, json(), withAdminController(createPostAdminLoginController)) |
| // codeql[js/missing-rate-limiting] - feature gate only, not authentication | ||
| router.use(adminEnabledMiddleware) | ||
| router.post('/login', adminLoginRateLimitMiddleware, json(), withAdminController(createPostAdminLoginController)) | ||
| router.get('/session', adminRateLimitMiddleware, adminAuthMiddleware, withAdminController(createGetAdminSessionController)) |
| router.post('/login', adminLoginRateLimitMiddleware, json(), withAdminController(createPostAdminLoginController)) | ||
| router.get('/session', adminRateLimitMiddleware, adminAuthMiddleware, withAdminController(createGetAdminSessionController)) | ||
| router.get('/health', adminRateLimitMiddleware, adminAuthMiddleware, withAdminController(createGetAdminHealthController)) | ||
| router.get('/metrics', adminRateLimitMiddleware, adminAuthMiddleware, withAdminController(createGetAdminMetricsController)) |
Collaborator
|
coverage: 67.576% (+0.8%) from 66.747% — Ferryx349:ADMIN-CONSOLE-2-SSE into cameri:main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
GET /admin/metricsas an authenticated SSE stream for the admin console.Related Issue
Fixes - #655
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: