Fix: Path safety. (mkdir if path not already exist, check path)#223
Open
mary4net wants to merge 3 commits into
Open
Fix: Path safety. (mkdir if path not already exist, check path)#223mary4net wants to merge 3 commits into
mary4net wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The original version does the generation before checking the path. If the path does not already exist, the saving will fail and crash, which is a waste of token.
The Fix
Added path check, if path not already exist, then create it.
If couldn't create the file, the error will stop the program before starting to generate anything.
Fixed variable name (twitter_channel -> platform_channel).