fix: guard ReadTarEntry against decompression bombs (OOM)#2593
Open
jkutner wants to merge 1 commit into
Open
Conversation
Member
Author
|
@jjbustamante can you take a look at this? It's meant to address pack OOM via decompression bomb in buildpack descriptor read, but i'm not sure if this will cause other issues. |
…riptor read Signed-off-by: Joe Kutner <jpkutner@gmail.com>
f40c8b3 to
feac3f5
Compare
Member
I have issues with accessing the maintainers message (it is attached to my Broadcom email account) could you send me the Of Out Memory message? @jkutner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxTarEntrySizeconstant (4 MB) topkg/archive/archive.goReadTarEntrynow rejects entries whose declaredheader.Sizeexceeds the limit before reading any dataio.LimitReader+ byte-count check catches malformed archives where the header size is understatedMotivation
A malicious or malformed buildpack image could include a tar entry (e.g.
buildpack.toml/lifecycle.toml) with an arbitrarily large payload.ReadTarEntrypreviously calledio.ReadAllwith no bound, allowing a decompression bomb to exhaust heap memory. This is CVSS 3.1 score 6.5.Test plan
go test ./pkg/archive/... -run TestArchive/Archive/#ReadTarEntry— all 6 cases passmake build— binary builds cleanlymake lint— 0 issuesmake tidy— no changes