Consolidate trust logic into IsTrustedBuilder#2573
Open
runesoerensen wants to merge 3 commits into
Open
Conversation
github-actions
Bot
added
the
type/enhancement
1 task
…ilders Signed-off-by: Rune Soerensen <rsoerensen@salesforce.com>
Signed-off-by: Rune Soerensen <rsoerensen@salesforce.com>
runesoerensen
force-pushed
the
runesoerensen/consolidate-trusted-builder-logic
branch
from
ad1df62 to
85e15fc
Compare
Contributor
Author
|
@jjbustamante thanks for reviewing/merging #2571! This branch was based on that work, so I've rebased and marked the PR ready for review :) |
| h.AssertTrue(t, isTrusted) | ||
|
|
||
| // Known builder without tag should match any tag | ||
| isTrusted, err = bldr.IsTrustedBuilder(config.Config{}, "paketobuildpacks/builder-jammy-base:latest") |
Member
There was a problem hiding this comment.
Should this test case reference: paketobuildpacks/builder-jammy-base?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate all trust checking into
IsTrustedBuilderso callers don't need to separately checkIsKnownTrustedBuilder(), and usename.ParseReferencefor consistent reference matching across both known and user-configured builders.IsTrustedBuildernow checks both known trusted builders and user-configured trusted buildersname.ParseReferencefor consistent reference matching across both sources - entries without a tag match any tag in the repository, entries with a tag require an exact match|| IsKnownTrustedBuilder()calls frombuild.go,config_trusted_builder.go, andbuilder_inspect.goOutput
Before
After
Documentation
Related
Resolves #2572