fix(7552): prevent branch names starting with hex chars from matching commit ID pattern#7576
Open
Gbolahan-Aziz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7552
When a Terraform module source uses a
?ref=value that is a branch name starting with hex characters (e.g.1014016-chekov-branch-bug), Checkov incorrectly identifies the hex prefix as a commit ID.COMMIT_ID_PATTERNlacked an end anchor, sore.subwould strip only the matched hex portion (e.g.?ref=1014016) from the URL, leaving the remainder (-chekov-branch-bug) dangling — which then got appended to the repository name, producing a clone address that does not exist:The fix adds
(?:&|$)toCOMMIT_ID_PATTERNso it only matches a ref value that is purely hexadecimal with nothing following it. Branch/tag names that start with hex characters now fall through toTAG_PATTERNand are cloned correctly.Checklist: