Skip to content

Implement bcloud CLI with YAML configuration and key-as-ref_id pattern #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Implement bcloud CLI with YAML configuration and key-as-ref_id pattern #22

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
902ee4e
Implement bcloud CLI with YAML configuration and key-as-ref_id pattern
devin-ai-integration[bot] Aug 9, 2025
59ac5e6
Add example credentials configuration file for CLI usage
devin-ai-integration[bot] Aug 9, 2025
54b4689
Refactor to use pkg/v1.CloudCredential interface as requested in PR f…
devin-ai-integration[bot] Aug 9, 2025
81666d1
Address GitHub feedback: simplify credential system using existing SD…
devin-ai-integration[bot] Aug 9, 2025
b934902
Add comprehensive testing for config.go LoadConfig and credential par…
devin-ai-integration[bot] Aug 10, 2025
5151264
Implement GitHub feedback: add JSON tags and unify provider IDs
devin-ai-integration[bot] Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions cmd/bcloud/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ import (

var providerRegistry = map[string]func() v1.CloudCredential{}

var providerIDToRegistryKey = map[string]string{
"lambda-labs": "lambdalabs",
Copy link
Copy Markdown
Member

@theFong theFong Aug 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should be the same (provider id and registry key) strings lets refactor

"nebius": "nebius",
}

func RegisterProvider(id string, factory func() v1.CloudCredential) {
providerRegistry[id] = factory
}
Expand Down Expand Up @@ -67,14 +72,18 @@ func (c *CredentialEntry) decodeFromMap(m map[string]any, yamlKey string) error
if !ok || provider == "" {
return fmt.Errorf("invalid 'provider'")
}
factory, ok := providerRegistry[provider]
registryKey := provider
if mappedKey, exists := providerIDToRegistryKey[provider]; exists {
registryKey = mappedKey
}
factory, ok := providerRegistry[registryKey]
if !ok {
return fmt.Errorf("unknown provider: %s", provider)
}
cred := factory()

if _, hasRefID := m["ref_id"]; !hasRefID {
m["ref_id"] = yamlKey
if _, hasRefID := m["RefID"]; !hasRefID {
Copy link
Copy Markdown
Member

@theFong theFong Aug 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go in to the provider credential and use tags to change them to ref_id api_key etc.

m["RefID"] = yamlKey
}

b, err := json.Marshal(m)
Expand All @@ -85,7 +94,7 @@ func (c *CredentialEntry) decodeFromMap(m map[string]any, yamlKey string) error
return err
}

c.Provider = provider
c.Provider = registryKey
c.Value = cred
return nil
}
Expand Down
Loading